[PageAction] Add support for chrome.pageAction.setIcon on Android

REOPENED
Assigned to

Status

()

Toolkit
WebExtensions: Android
P3
normal
REOPENED
a year ago
2 months ago

People

(Reporter: mattw, Assigned: mattw)

Tracking

(Blocks: 1 bug)

unspecified
Unspecified
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [pageAction]triaged)

(Assignee)

Description

a year ago
This bug is meant to track the implementation and testing of Chrome.pageAction.setIcon on android.

Firefox docs: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/PageAction/setIcon
Chrome docs: https://developer.chrome.com/extensions/pageAction#method-setIcon

Notes: There isn't an existing method in the PageActions.jsm module that we can wrap, but we should be able to add one by doing the following:
 - Add a new method to PageActions.jsm for setting the icon, which uses `Messaging.sendRequest(...)` to send a new message, maybe "PageActions:UpdateIcon" with the id of the PageAction returned by `PageActions.add(...)`.
 - Add a new case to handleUiMessage in PageActionLayout.java which updates the icon when the "PageActions:UpdateIcon" message is received.
(Assignee)

Updated

a year ago
Whiteboard: triaged → [pageAction]triaged
(Assignee)

Updated

a year ago
Assignee: nobody → mwein
(Assignee)

Comment 1

a year ago
This change will be a part of https://bugzilla.mozilla.org/show_bug.cgi?id=1270742.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
(Assignee)

Comment 2

9 months ago
Reopening as it didn't actually end up being a part of bug 1270742.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

Updated

7 months ago
Component: WebExtensions: Untriaged → WebExtensions: Android
Priority: -- → P3
(Assignee)

Updated

2 months ago
webextensions: --- → ?
You need to log in before you can comment on or make changes to this bug.