1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Metrics, defect)

Description

[Mark Capella [:capella]]

As promised in bug 1257843 comment 12, this will be the standalone patch to measure current Text Selection use that can be moved ahead of Aurora, in Beta, Release as needed.

Comment 1

[Mark Capella [:capella]]

Attachment: MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

Review commit: https://reviewboard.mozilla.org/r/48795/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48795/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8745050 [details]
MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

https://reviewboard.mozilla.org/r/48795/#review45773

::: mobile/android/base/java/org/mozilla/gecko/ActionBarTextSelection.java:157
(Diff revision 1)
>              @Override
>              public void run() {
>                  try {
>                      if (event.equals("TextSelection:ShowHandles")) {
> +                        Telemetry.sendUIEvent(TelemetryContract.Event.SHOW,
> +                            TelemetryContract.Method.CONTENT, "text_selection_orig");

Just use "text_selection" here too. We can filter by version in redash. :)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2b5f2f914c3c

Comment 4

[Mark Capella [:capella]]

ni? to self, followup by push to at least aurora ... don't forget req'd add'l imports

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Mark Capella [:capella] from comment #4)
> ni? to self, followup by push to at least aurora ... don't forget req'd
> add'l imports

Your patch from bug 1257843 should be in Aurora (Merge day was yesterday). So this should only need to be in beta (Assuming that Aurora and Nightly have accessiblecaret enabled now).

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2b5f2f914c3c

Comment 7

[Mark Capella [:capella]]

Comment on attachment 8745050 [details]
MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

Approval Request Comment: Enables Telemetry collection before/after a feature is introduced ... feature is currently in Aurora, we need to get this Telemetry patch in Aurora and Beta to enable that.

*********** A modified version of this patch is required for Beta to build properly.

[Feature/regressing bug #]: N/A
[User impact if declined]: Telemetry for old version of the feature won't be collected for comparison to the new version.

[Describe test coverage new/current, TreeHerder]: Small patch, built fine, passed all try, in m-c already for several days now.

[Risks and why]: s/b none to zero.
[String/UUID change made/needed]: none.

Comment 8

[Mark Capella [:capella]]

Attachment: beta_bug1267383.diff

Adapted version for BETA

Comment 9

[Mark Capella [:capella]]

Attachment: beta_bug1267383.diff

/Getting the flags straight/

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

Comment on attachment 8745050 [details]
MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

Approval Request Comment: Enables Telemetry collection before/after a feature is introduced ... feature is currently in Aurora, we need to get this Telemetry patch in Aurora and Beta to enable that.

*********** A modified version of this patch is required for Beta to build properly.

[Feature/regressing bug #]: N/A
[User impact if declined]: Telemetry for old version of the feature won't be collected for comparison to the new version.

[Describe test coverage new/current, TreeHerder]: Small patch, built fine, passed all try, in m-c already for several days now.

[Risks and why]: s/b none to zero.
[String/UUID change made/needed]: none.

Comment 10

[Mark Capella [:capella]]

Comment on attachment 8745050 [details]
MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

Limit this patch request to aurora

Comment 11

[Mark Capella [:capella]]

Sorry for bugspam, new to mozreview, so ensuring;

The patch for aurora is the one that was pushed to m-c
https://hg.mozilla.org/mozilla-central/rev/2b5f2f914c3c

The patch for beta will be the one attached:
https://bugzilla.mozilla.org/attachment.cgi?id=8747053

Comment 12

[Mark Capella [:capella]]

Gah, I promise this is the last time   >:-|

The patch for aurora is the one that was pushed to m-c
https://hg.mozilla.org/mozilla-central/rev/2b5f2f914c3c

The patch for beta will be the one attached:
https://bugzilla.mozilla.org/attachment.cgi?id=8747056&action=diff

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8747056 [details] [diff] [review]
beta_bug1267383.diff

Telemetry related, Beta47+

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8745050 [details]
MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

Aurora48+

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4dc991401578

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/45b55758ff66