Closed Bug 1267383 Opened 4 years ago Closed 4 years ago

Followup Telemetry from Bug 1257843, Text Selection Probe

Categories

(Firefox for Android :: Metrics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox47 --- fixed
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: capella, Assigned: capella)

Details

Attachments

(2 files, 1 obsolete file)

As promised in bug 1257843 comment 12, this will be the standalone patch to measure current Text Selection use that can be moved ahead of Aurora, in Beta, Release as needed.
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Comment on attachment 8745050 [details]
MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

https://reviewboard.mozilla.org/r/48795/#review45773

::: mobile/android/base/java/org/mozilla/gecko/ActionBarTextSelection.java:157
(Diff revision 1)
>              @Override
>              public void run() {
>                  try {
>                      if (event.equals("TextSelection:ShowHandles")) {
> +                        Telemetry.sendUIEvent(TelemetryContract.Event.SHOW,
> +                            TelemetryContract.Method.CONTENT, "text_selection_orig");

Just use "text_selection" here too. We can filter by version in redash. :)
Attachment #8745050 - Flags: review?(s.kaspari) → review+
ni? to self, followup by push to at least aurora ... don't forget req'd add'l imports
Flags: needinfo?(markcapella)
(In reply to Mark Capella [:capella] from comment #4)
> ni? to self, followup by push to at least aurora ... don't forget req'd
> add'l imports

Your patch from bug 1257843 should be in Aurora (Merge day was yesterday). So this should only need to be in beta (Assuming that Aurora and Nightly have accessiblecaret enabled now).
https://hg.mozilla.org/mozilla-central/rev/2b5f2f914c3c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8745050 [details]
MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

Approval Request Comment: Enables Telemetry collection before/after a feature is introduced ... feature is currently in Aurora, we need to get this Telemetry patch in Aurora and Beta to enable that.

*********** A modified version of this patch is required for Beta to build properly.

[Feature/regressing bug #]: N/A
[User impact if declined]: Telemetry for old version of the feature won't be collected for comparison to the new version.

[Describe test coverage new/current, TreeHerder]: Small patch, built fine, passed all try, in m-c already for several days now.

[Risks and why]: s/b none to zero.
[String/UUID change made/needed]: none.
Flags: needinfo?(markcapella)
Attachment #8745050 - Flags: approval-mozilla-beta?
Attachment #8745050 - Flags: approval-mozilla-aurora?
Attached patch beta_bug1267383.diff (obsolete) — Splinter Review
Adapted version for BETA
/Getting the flags straight/

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

Comment on attachment 8745050 [details]
MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

Approval Request Comment: Enables Telemetry collection before/after a feature is introduced ... feature is currently in Aurora, we need to get this Telemetry patch in Aurora and Beta to enable that.

*********** A modified version of this patch is required for Beta to build properly.

[Feature/regressing bug #]: N/A
[User impact if declined]: Telemetry for old version of the feature won't be collected for comparison to the new version.

[Describe test coverage new/current, TreeHerder]: Small patch, built fine, passed all try, in m-c already for several days now.

[Risks and why]: s/b none to zero.
[String/UUID change made/needed]: none.
Attachment #8747053 - Attachment is obsolete: true
Attachment #8747056 - Flags: approval-mozilla-beta?
Comment on attachment 8745050 [details]
MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

Limit this patch request to aurora
Attachment #8745050 - Flags: approval-mozilla-beta?
Sorry for bugspam, new to mozreview, so ensuring;

The patch for aurora is the one that was pushed to m-c
https://hg.mozilla.org/mozilla-central/rev/2b5f2f914c3c

The patch for beta will be the one attached:
https://bugzilla.mozilla.org/attachment.cgi?id=8747053
Gah, I promise this is the last time   >:-|

The patch for aurora is the one that was pushed to m-c
https://hg.mozilla.org/mozilla-central/rev/2b5f2f914c3c

The patch for beta will be the one attached:
https://bugzilla.mozilla.org/attachment.cgi?id=8747056&action=diff
Comment on attachment 8747056 [details] [diff] [review]
beta_bug1267383.diff

Telemetry related, Beta47+
Attachment #8747056 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 8745050 [details]
MozReview Request: Bug 1267383 - Followup Telemetry from Bug 1257843, Text Selection Probe, r=sebastian

Aurora48+
Attachment #8745050 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.