1267433 - Memory tool clear toolbar button has different position than other clear buttons

Status: NEW

(DevTools :: Memory, defect, P2)

Description

[Tim Nguyen :ntim]

This line: https://hg.mozilla.org/mozilla-central/annotate/fc15477ce628599519cb0055f52cc195d640dc94/devtools/client/themes/memory.css#l125
is causing the issue.

It was removed in https://hg.mozilla.org/integration/fx-team/rev/cad934baac3c#l5.17

then re-added (probably due to a bad rebase) in https://hg.mozilla.org/mozilla-central/rev/4cbe058eacf8#l62.41

Comment 1

[Tim Nguyen :ntim]

Nick, any chance you can take a look at this ?

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Fix memory tool clear button css

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8746770 [details] [diff] [review]
Fix memory tool clear button css

Review of attachment 8746770 [details] [diff] [review]:
-----------------------------------------------------------------

This line that should have been removed is the one with #clear-snapshots

Comment 4

[Tim Nguyen :ntim]

(In reply to Tim Nguyen :ntim from comment #3)
> Comment on attachment 8746770 [details] [diff] [review]
> Fix memory tool clear button css
> 
> Review of attachment 8746770 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This line that should have been removed is the one with #clear-snapshots

Actually -moz-box-align: center also needs to be removed. Can you update the patch to remove both? Thanks!

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

This is not my priority right now.