Closed Bug 126744 Opened 24 years ago Closed 24 years ago

change system encoding for chinese window from gb2312 to gb18030

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.0

People

(Reporter: ftang, Assigned: ftang)

References

Details

(Keywords: intl)

Attachments

(1 file, 1 obsolete file)

changing case
496 bytes, patch
ftang
: review+
asa
: approval+
Details | Diff | Splinter Review
the current system encoding of simp chinese window is gb2312, we should change it to the new gb18030.
we should change http://lxr.mozilla.org/seamonkey/source/intl/uconv/src/wincharset.properties from acp.936=GB2312 to acp.936=GB18030
Keywords: nsbeta1
Keywords: intl
QA Contact: ruixu → ylong
since GB18030 can encode all the Unicode, in this way we can encode all the unicode in the file name.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
Blocks: 104056
shanjian, can you r= this one? GB18030 can encode all the unicode. and CP949 can encode more Unicode than EUC-KR and are backward compatabile with EUC-KR.
Comment on attachment 70939 [details] [diff] [review] patch for both bug 126744 and bug 126752 /r=yokoyama
Attachment #70939 - Flags: review+
ruixu, could you change your res/wincharset.property and test them on SC and KO windows. This patch won't impact non window platform neither platforms other than simplified chinese and korean.
ask for sr=
Blocks: 104148
No longer blocks: 104056
Comment on attachment 70939 [details] [diff] [review] patch for both bug 126744 and bug 126752 sr=alecf
Attachment #70939 - Flags: superreview+
Blocks: 104060
No longer blocks: 104148
I don't think this change will impact profile manager now since alecf change the nsLocalFile to use the win api instead of xp api. :( We may want to take this for other reason. (copy&paste ? )
We probably should still land this patch for korean c&p.
Tested on KO Win2K, SC Win2K and SC WinXP with GB18030 font pre-installed. As Frank mentioned above, we still have some unicode problems on profile name creating, file saving, etc..
fixed and check into trunk
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Keywords: nsbeta1 → nsbeta1+
No longer blocks: 104060
GB18030 decoder doesn't work. it appears that it is case-sensitive. We need to change acp.936=GB18030 to acp.936=gb18030 I'll attach a patch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch changing case — — Splinter Review
ftang/shanjian: please review.
Attachment #70939 - Attachment is obsolete: true
Comment on attachment 73086 [details] [diff] [review] changing case r=ftang
Attachment #73086 - Flags: review+
Comment on attachment 73086 [details] [diff] [review] changing case a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #73086 - Flags: approval+
Blocks: 104060
Status: REOPENED → ASSIGNED
patch (03/07/02 16:14) checked in.
Marking as fixed. We have done what the summary says. "change system encoding for chinese window from gb2312 to gb18030" Changing QA to shanjian
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
QA Contact: ylong → shanjian
Resolution: --- → FIXED
No longer blocks: 104060
Blocks: 100243
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: