126744 - change system encoding for chinese window from gb2312 to gb18030

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Frank Tang]

the current system encoding of simp chinese window is gb2312, we should change
it to the new gb18030.

Comment 1

[Frank Tang]

we should change 
http://lxr.mozilla.org/seamonkey/source/intl/uconv/src/wincharset.properties
from 
acp.936=GB2312

to
acp.936=GB18030

Comment 2

[Frank Tang]

since GB18030 can encode all the Unicode, in this way we can encode all the
unicode in the file name. 

Comment 3

[Frank Tang]

Attachment: patch for both bug 126744 and bug 126752

Comment 4

[Frank Tang]

shanjian, can you r= this one?
GB18030 can encode all the unicode.
and CP949 can encode more Unicode than EUC-KR and are backward compatabile with
EUC-KR.

Comment 5

[Roy Yokoyama]

Comment on attachment 70939 [details] [diff] [review]
patch for both bug 126744 and bug 126752

/r=yokoyama

Comment 6

[Frank Tang]

ruixu, could you change your res/wincharset.property and test them on SC and KO
windows. This patch won't impact non window platform neither platforms other
than simplified chinese and korean. 

Comment 7

[Frank Tang]

ask for sr=

Comment 8

[Alec Flett]

Comment on attachment 70939 [details] [diff] [review]
patch for both bug 126744 and bug 126752

sr=alecf

Comment 9

[Frank Tang]

I don't think this change will impact profile manager now since alecf change the
nsLocalFile to use the win api instead of xp api. :(
We may want to take this for other reason. (copy&paste ? )

Comment 10

[Frank Tang]

We probably should still land this patch for korean c&p.

Comment 11

[Rui Xu]

Tested on KO Win2K, SC Win2K and SC WinXP with GB18030 font pre-installed. As 
Frank mentioned above, we still have some unicode problems on profile name 
creating, file saving, etc..

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 70939 [details] [diff] [review]
patch for both bug 126744 and bug 126752

a=dbaron for 0.9.9

Comment 13

[Frank Tang]

fixed and check into trunk

Comment 14

[Roy Yokoyama]

GB18030 decoder doesn't work.
it appears that it is case-sensitive.   We need to
change  acp.936=GB18030 to acp.936=gb18030
I'll attach a patch

Comment 15

[Roy Yokoyama]

Attachment: changing case

ftang/shanjian: please review.

Comment 16

[Frank Tang]

Comment on attachment 73086 [details] [diff] [review]
changing case

r=ftang

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 73086 [details] [diff] [review]
changing case

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 18

[Roy Yokoyama]

patch (03/07/02 16:14) checked in.

Comment 19

[Roy Yokoyama]

Marking as fixed.
We have done what the summary says.
"change system encoding for chinese window from gb2312 to gb18030"
Changing QA to shanjian