Closed Bug 1267514 Opened 4 years ago Closed 4 years ago

about:neterror/certerror fallback is broken (it breaks if the error code does not match an existing element)

Categories

(Firefox :: General, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 49
Iteration:
49.2 - May 23
Tracking Status
firefox47 --- unaffected
firefox48 --- verified
firefox49 --- verified

People

(Reporter: magicp.jp, Assigned: nhnt11)

References

()

Details

(Keywords: regression, Whiteboard: [fxprivacy])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160425102203

Steps to reproduce:

1. Start latest Nightly
2. Go to about:neterror (or about:certerror)


Actual results:

Cannot display the problem loading page (Oops.) with correct layout.


Expected results:

Displays the problem loading page with correct layout.
Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=ab85f19b67b1d093e060bfe52a672a3a9995e252&tochange=9062049993e1fe1d4ca4d0c45155b6502206459c
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Theme
OS: Unspecified → All
Hardware: Unspecified → All
Does this happen with actual error pages (and if so, can you give an example?) or just if you manually navigate to about:neterror / about:certerror ?
Flags: needinfo?(magicp.jp)
This seems restricted to cases where we have no error-specific error message.

Nihanth, can you take this?
Component: Theme → General
Flags: needinfo?(magicp.jp) → needinfo?(nhnt11)
Summary: Cannot display the problem loading page with correct layout → about:neterror/certerror fallback is broken (it breaks if the error code does not match an existing element)
Assigning.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Flags: needinfo?(nhnt11)
Duplicate of this bug: 1268079
Browser console ha this clue (maybe you've already discovered it):
> TypeError: document.getElementById(...) is null
> initPage()
> /:220

If I click the source link there, I'm taken to the getElementById call here:
>      function initPage()
>      {
[...]
>        // if it's an unknown error or there's no title or description
>        // defined, get the generic message
>        var errTitle = document.getElementById("et_" + err).innerHTML;
Source link:
http://hg.mozilla.org/mozilla-central/annotate/ab0044bfa1df/browser/base/content/aboutNetError.xhtml#l220

That's from bug 1220481. I'm assuming this is a regression from that bug.
Blocks: 1220481
Keywords: regression
(In reply to Daniel Holbert [:dholbert] from comment #6)
> Browser console ha this clue (maybe you've already discovered it):
> > TypeError: document.getElementById(...) is null
> > initPage()
> > /:220
> 
> If I click the source link there, I'm taken to the getElementById call here:
> >      function initPage()
> >      {
> [...]
> >        // if it's an unknown error or there's no title or description
> >        // defined, get the generic message
> >        var errTitle = document.getElementById("et_" + err).innerHTML;
> Source link:
> http://hg.mozilla.org/mozilla-central/annotate/ab0044bfa1df/browser/base/
> content/aboutNetError.xhtml#l220
> 
> That's from bug 1220481. I'm assuming this is a regression from that bug.

Yes, this was implied from comment #1, but I forgot to add the bug to the list of 'blocking' this bug - thanks for doing that!

Note that this is only an issue if you manually open about:neterror, not for any other actual error pages that I've seen - yet - but it could in principle also happen for "real" errors if we ever pass errors for which there is no definite message in the html page right now. I don't know if there are such errors.
I am testing manually navigate to about:neterror/about:certerror for third-party complete themes. also attack and trap sites. Anyway no layout collapse bugs in Firefox 47 and lower version.
Comment on attachment 8748412 [details]
MozReview Request: Bug 1267514 - Fix about:neterror generic fallback text when there is no available title/description for the error. r=Gijs

https://reviewboard.mozilla.org/r/50265/#review47169
Attachment #8748412 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/integration/fx-team/rev/9428c76cb9df77442a54cd68cae5a8426ba334a7
Bug 1267514 - Fix about:neterror generic fallback text when there is no available title/description for the error. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/9428c76cb9df
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Blocks: 1216897
Iteration: --- → 49.2 - May 23
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [fxprivacy]
Comment on attachment 8748412 [details]
MozReview Request: Bug 1267514 - Fix about:neterror generic fallback text when there is no available title/description for the error. r=Gijs

Approval Request Comment
[Feature/regressing bug #]: bug 1220481
[User impact if declined]: in some edgecases network error pages don't provide any information / look broken
[Describe test coverage new/current, TreeHerder]: nope. :-(
[Risks and why]: low risk, minor change to fallback handling of network error pages
[String/UUID change made/needed]: no.
Attachment #8748412 - Flags: approval-mozilla-aurora?
Comment on attachment 8748412 [details]
MozReview Request: Bug 1267514 - Fix about:neterror generic fallback text when there is no available title/description for the error. r=Gijs

Fix for recent regression, please uplift to aurora
Attachment #8748412 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
It would be good to verify this on aurora once it lands.
Flags: qe-verify? → qe-verify+
QA Contact: paul.silaghi
Reproduced on Nightly 49.0a1 (2016-05-09).
Verified fixed 48.0a2 (2016-05-24), 49.0a1 (2016-05-25) Win 7.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.