Closed Bug 1267530 Opened 4 years ago Closed 4 years ago

Add some profiler marker for fullscreen transition

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

(Whiteboard: btpp-active)

Attachments

(2 files)

It would be useful to add profiler marker for fullscreen transition so that we know the exact point each phase of the transition starts from the profile report.

This may make analysing any slowness of fullscreen transition easier.
Assignee: nobody → bugzilla
Comment on attachment 8746401 [details]
MozReview Request: Bug 1267530 part 1 - Add some profiler marker for fullscreen transition. r=smaug,BenWa

https://reviewboard.mozilla.org/r/49409/#review46225

Marker usage looks good to me. I'll leave it up to smaug to decide if you've got the relevant fullscreen code.
Attachment #8746401 - Flags: review?(bgirard) → review+
Comment on attachment 8746401 [details]
MozReview Request: Bug 1267530 part 1 - Add some profiler marker for fullscreen transition. r=smaug,BenWa

https://reviewboard.mozilla.org/r/49409/#review46223

I couldn't remember the ordering of this all, but thanks for explaining.
It would be great to have some ascii art explaining the different stages in different processes.
Anyhow, having marker for this stuff can be useful.
Attachment #8746401 - Flags: review?(bugs) → review+
Review commit: https://reviewboard.mozilla.org/r/49419/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49419/
Attachment #8746401 - Attachment description: MozReview Request: Bug 1267530 - Add some profiler marker for fullscreen transition. r?smaug r?BenWa → MozReview Request: Bug 1267530 part 1 - Add some profiler marker for fullscreen transition. r=smaug,BenWa
Attachment #8746416 - Flags: review?(bugs)
Comment on attachment 8746401 [details]
MozReview Request: Bug 1267530 part 1 - Add some profiler marker for fullscreen transition. r=smaug,BenWa

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49409/diff/1-2/
Comment on attachment 8746416 [details]
MozReview Request: Bug 1267530 part 2 - Add ASCII art explaination of flow of fullscreen transition. r?smaug

https://reviewboard.mozilla.org/r/49419/#review46255

thanks!
Attachment #8746416 - Flags: review?(bugs) → review+
Whiteboard: btpp-active
https://hg.mozilla.org/integration/mozilla-inbound/rev/914eba686417f7a2d82098c8e3026902671298f4
Bug 1267530 part 1 - Add some profiler marker for fullscreen transition. r=smaug,BenWa

https://hg.mozilla.org/integration/mozilla-inbound/rev/42f8c2e67ba766e974866dbadbafb9ad7c8e0cab
Bug 1267530 part 2 - Add ASCII art explaination of flow of fullscreen transition. r=smaug
https://hg.mozilla.org/mozilla-central/rev/914eba686417
https://hg.mozilla.org/mozilla-central/rev/42f8c2e67ba7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.