Closed Bug 1267592 Opened 4 years ago Closed Last year

"Select all" context menu option doesn't work in presentation mode using pdf.js

Categories

(Firefox :: PDF Viewer, defect, P4, minor)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox46 --- affected
firefox47 --- affected
firefox48 --- affected
firefox49 --- affected
firefox-esr38 --- affected

People

(Reporter: JuliaC, Unassigned)

References

Details

(Keywords: regression, Whiteboard: [pdfjs-c-ux])

[Affected versions]:
- 38.8.0esr build1
- latest Nightly 
- latest Aurora
- 47.0b1 build1 (20160425095909)
- 46.0 build5 (20160421124000)
- 45.0.2 build1 (20160407164938)

[Affected platforms]:
- Mac OS X 10.9.5   
- Windows 10 x64
- Ubuntu 14.04 x32

[Steps to reproduce]:
1. Launch Firefox
2. Open a random *.pdf file (e.g. http://cp.literature.agilent.com/litweb/pdf/5989-8139EN.pdf)
3. Click the "Switch to Presentation Mode" button
4. Right click in the document and choose the "Select All" context menu option.

[Expected result]:
- The entire content is selected in every document's page.

[Actual result]:
- Nothing in the document is selected; the "Select All" context menu option does nothing.
- If the Presentation Mode is designed only for full-screen reading, the "Select All" option shouldn't be part of context menu.

[Regression range]:
- I didn't yet have the time to see whether this is a regression or not, but I'll check it as soon as possible.
bug 1110260: #5478 Prevent text selection in Presentation Mode (bug 1018882)
Blocks: 1018882
Has Regression Range: --- → yes
Has STR: --- → yes
Whiteboard: [good first bug]
Version: Trunk → 37 Branch
(In reply to YF (Yang) from comment #1)
> bug 1110260: #5478 Prevent text selection in Presentation Mode (bug 1018882)

- The regressionwindow-wanted keyword is set as our team's rule concerning those bugs that haven't been verified for a regression yet, but they are possible ones.
- The issue is affecting more than the 37 Branch: 38.8.0esr build1, latest Nightly, latest Aurora, 47.0b1 build1, 46.0 build5, 45.0.2 build1 -> so, this is a trunk issue.
- Indeed, the Bug 1018882 proves that "Select all" context menu option was once working in presentation mode using pdf.js.
- The "#5478 Prevent text selection in Presentation Mode" is supposed to be fixed since 2014-12-16, but the "Select All" option is still part of context menu. This is a contradiction. As I've already said, if text selection isn't wanted for Presentation Mode, the "Select All" option shouldn't be part of context menu. Its presence is confusing the user.
Version: 37 Branch → Trunk
(In reply to Iulia Cristescu, QA [:IuliaC] from comment #2)
> (In reply to YF (Yang) from comment #1)
> > bug 1110260: #5478 Prevent text selection in Presentation Mode (bug 1018882)
> 
> - The regressionwindow-wanted keyword is set as our team's rule concerning
> those bugs that haven't been verified for a regression yet, but they are
> possible ones.

It apparently to work when bug 1018882, even though I have not verified it.

> - The issue is affecting more than the 37 Branch: 38.8.0esr build1, latest
> Nightly, latest Aurora, 47.0b1 build1, 46.0 build5, 45.0.2 build1 -> so,
> this is a trunk issue.

https://bugzilla.mozilla.org/page.cgi?id=fields.html#version
Version
    The version field defines the version of the software the bug was found in. 

I think that it can serve as a first version of found problem, more meaningful compared to trunk.

> - Indeed, the Bug 1018882 proves that "Select all" context menu option was
> once working in presentation mode using pdf.js.
> - The "#5478 Prevent text selection in Presentation Mode" is supposed to be
> fixed since 2014-12-16, but the "Select All" option is still part of context
> menu. This is a contradiction. As I've already said, if text selection isn't
> wanted for Presentation Mode, the "Select All" option shouldn't be part of
> context menu. Its presence is confusing the user.

So this bug be to NEW, it is an existing issue, and I think it does not need a window.
> - Nothing in the document is selected; the "Select All" context menu option
> does nothing.
> - If the Presentation Mode is designed only for full-screen reading, the
> "Select All" option shouldn't be part of context menu.

Text selection is purposely disabled in Presentation Mode, since it's intended for reading/showing presentations, note how e.g. Ctrl + A is also ignored. Hence I do not think that this is a regression.

Furthermore, since the PDFViewer is (basically) a web page, I'm not sure if it's even possible (or feasible) to remove the "Select all" context menu entry, since that is part of the browser.
Whiteboard: [good first bug]
(In reply to Jonas Jenwald [:Snuffleupagus] from comment #4)
> Text selection is purposely disabled in Presentation Mode, since it's
> intended for reading/showing presentations, note how e.g. Ctrl + A is also
> ignored. Hence I do not think that this is a regression.
> 
> Furthermore, since the PDFViewer is (basically) a web page, I'm not sure if
> it's even possible (or feasible) to remove the "Select all" context menu
> entry, since that is part of the browser.

Hello! Thank you for your opinion! Yes, you are right, this is not a regression, because "#5478 Prevent text selection in Presentation Mode" was aimed through Bug 1110260 fixing. 

This is what I want to highlight through this issue: since the select feature is intended to be unavailable in Presentation Mode, it should be either removed, either disabled from the context menu. 

I point out again that this situation creates confusion for users, especially because all the others available context menu options are active and functional. From the user's perspective, it is strange and annoying to have an available context menu option that is inactive.
Flags: needinfo?(ydelendik)
Flags: needinfo?(bdahl)
Iulia, I'm not sure what purpose of NI is there. I'll remove it. 

I'm going to triage this. But so far, it's "won't fix" due to limitation of the web platform: a web application (PDF Viewer is one of them) cannot control state of "Select All". And providing hooks to disable context menu (which will be a solution) will require significant amount effort in implementation, documentation and testing, as well as it's connected with security risks. Taking these trade-offs in account it's easier to leave with this corner case defect IMHO
Severity: normal → minor
Flags: needinfo?(ydelendik)
Flags: needinfo?(bdahl)
Priority: -- → P4
Whiteboard: [pdfjs-c-ux]
Closing as WONTFIX, based on comment 4 and comment 6.
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.