The default bug view has changed. See this FAQ.

TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js and test_csp_custom_policies.js

RESOLVED FIXED in Firefox 48

Status

()

Toolkit
WebExtensions: Untriaged
RESOLVED FIXED
11 months ago
12 days ago

People

(Reporter: Jorg K (GMT+1), Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
mozilla49
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
New on C-C since Apr 25, 2016:

TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/xpcshell/test_csp_custom_policies.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/xpcshell/test_csp_custom_policies.js | test_addon_csp - [test_addon_csp : 17] Expected base CSP value - "script-src 'self' https://* moz-extension: blob: filesystem: 'unsafe-eval' 'unsafe-inline'; object-src 'self' https://* moz-ext == "undefined"
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_implicit_id - [test_implicit_id : 28] null != null
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_implicit_id - [test_implicit_id : 221] A promise chain failed to handle a rejection: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.directoryEntries] - rejection date: Mon Apr 25 2016 06:56:38 GMT-0700 (Pacific Standard Time) - stack: JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: .cleanStagingDir :: line 7827
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_implicit_id - [test_implicit_id : 28] null != null
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_implicit_id - [test_implicit_id : 221] A promise chain failed to handle a rejection: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.directoryEntries] - rejection date: Mon Apr 25 2016 06:56:40 GMT-0700 (Pacific Standard Time) - stack: JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: .cleanStagingDir :: line 7827
Return code: 1
(Reporter)

Comment 1

11 months ago
Tests fail locally:
$ mozilla/mach xpcshell-test toolkit/components/extensions/test/xpcshell/test_csp_custom_policies.js
This is from bug 1254194. Kris, should this test be disabled for Thunderbird or how do we make it work?

$ mozilla/mach xpcshell-test toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js
This comes from bug 1262005. Robert, should this test be disabled for Thunderbird or how do we make it work?

Sorry for putting two issues into the same bug, but they are both related to web extensions. If necessary, I'll split it into bugs.

Kent, what's the tack TB is taking on web extensions?
Flags: needinfo?(rkent)
Flags: needinfo?(rhelmer)
Flags: needinfo?(kmaglione+bmo)

Comment 2

11 months ago
(In reply to Jorg K (GMT+2) from comment #1)
> Tests fail locally:
> $ mozilla/mach xpcshell-test
> toolkit/components/extensions/test/xpcshell/test_csp_custom_policies.js
> This is from bug 1254194. Kris, should this test be disabled for Thunderbird
> or how do we make it work?

The whole directory should probably be disabled.

> $ mozilla/mach xpcshell-test
> toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js
> This comes from bug 1262005. Robert, should this test be disabled for
> Thunderbird or how do we make it work?

It should be disabled.
Flags: needinfo?(rhelmer)
Flags: needinfo?(kmaglione+bmo)
(Reporter)

Comment 3

11 months ago
Created attachment 8745610 [details] [diff] [review]
Disable tests not suitable for Thunderbird.

Thanks for the quick reply. Here a patch that disables things as you suggested.
Attachment #8745610 - Flags: review?(kmaglione+bmo)

Updated

11 months ago
Attachment #8745610 - Flags: review?(kmaglione+bmo) → review+
(Reporter)

Comment 4

11 months ago
Comment on attachment 8745610 [details] [diff] [review]
Disable tests not suitable for Thunderbird.

Approval Request Comment
[Feature/regressing bug #]: Bug 1254194 and bug 1262005.
[User impact if declined]: None. But Thunderbird test suite fails.
[Risks and why]: No risk. Just disabling tests for Thunderbird test suite.
[String/UUID change made/needed]: None.

Bug 1254194 and bug 1262005 and were landed on mozilla48, so this needs to go there, too.
Attachment #8745610 - Flags: approval-mozilla-aurora?
(Reporter)

Updated

11 months ago
Component: General → WebExtensions
Product: Thunderbird → Toolkit
(Reporter)

Updated

11 months ago
Keywords: checkin-needed
(Reporter)

Comment 5

11 months ago
Dear Sheriff,

I know that rules say that you need a try run to use the "checkin-needed" service. Well, since this patch only disables tests for Thunderbird, there is no try run.

Comment 6

11 months ago
https://hg.mozilla.org/integration/fx-team/rev/ad483e29e70f
Keywords: checkin-needed

Comment 7

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ad483e29e70f
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49

Comment 8

11 months ago
"Kent, what's the tack TB is taking on web extensions?"

BWinton long ago advised us that web extensions made little sense for Thunderbird, and even if they did the web extensions group would be unlikely to accept patches for Thunderbird functionality. So we pretty much stopped looking further at any role web extensions might have with Thunderbird.
Flags: needinfo?(rkent)
(Reporter)

Comment 9

11 months ago
Gentle ping for Aurora approval. The change doesn't affect Firefox at all, it only disables a test for Thunderbird.
Flags: needinfo?(lhenry)

Comment 10

11 months ago
Approval isn't needed for test-only changes. It can land in Aurora with a=testonly.
(Reporter)

Comment 11

11 months ago
OK, and who do I ping to do it? Let's try a Sheriff.

Dear Sheriff, can you please push to Aurora as per comment #10.
Flags: needinfo?(lhenry) → needinfo?(cbook)

Updated

11 months ago
Flags: needinfo?(cbook)
Attachment #8745610 - Flags: approval-mozilla-aurora?

Comment 12

11 months ago
as Kris said no approval needed (and this might conflict with landing queries when there is still the request but no approval :) 

landed in https://hg.mozilla.org/releases/mozilla-aurora/rev/fdf6664b4ed7b2bc3cb5bbb4037fab9c71162358
status-firefox48: --- → fixed
(Reporter)

Updated

12 days ago
Blocks: 1346918
You need to log in before you can comment on or make changes to this bug.