1267644 - Hello copy panel overlaps with location bar results when typing

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect, P2)

Description

[Karla Merza [Away. Please needinfo? Brindusa Tot[:brindusat] ]]

Attachment: hello bug.png

[Prerequisites]:
- In about:config set the following preferences
  - loop.copy.ticket to 255
  - loop.copy.throttler to mozilla.org
  - loop.server to https://loop-dev.stage.mozaws.net/v0
- Have the Firefox Hello Beta 1.3.0 installed (https://addons.mozilla.org/en-US/firefox/addon/firefox-hello-beta/versions/?page=1#version-1.3.0)

[Affected versions]:
- Aurora 48.0a2, Nightly 48.0a1

[Affected platforms]:
- Linux 15.04, Mac OS 10.10, Windows 7

Scenario I:

[Steps to reproduce]:
1. Open browser.
2. Write something in the awesome bar.
3. Press CTRL+C.
4. Continue writing in the awesome bar. 

[Actual result]:
Hello pop-up is displayed over the search results.

Scenario II:

[Steps to reproduce]:
1. Open browser.
2. Write something in the awesome bar and press ENTER.
3. Click in the awesome bar and then press CTRL+C.
4. Continue writing in the awesome bar. 

[Actual result]:
Hello pop-up is displayed under the search results.

[Expected result]: (for both scenarios)
Hello pop-up should be dissmissed after step 4.

Comment 1

[Ian Bicking (:ianbicking)]

Attachment: Note no overlap in Fx47

I don't believe this happens in 46 (the target for 1.3) because the awesome bar is not full-width in this version.  Also in 47?  I've attached an example using 47 where the panel and the awesomebar do not conflict.

Comment 2

[Ed Lee :Mardak]

If the location bar results are already showing, should they be hidden when the user copies?

One possible approach could be to listen for popupshowing from the location bar to then hide the copy, e.g.,

> let onURLPopup = () => { copy.hidePopup(); };
> copy.addEventListener("popupshown", () => { gURLBar.popup.addEventListener("popupshown", onURLPopup); });
> copy.addEventListener("popuphidden", () => { gURLBar.popup.removeEventListener("popupshown", onURLPopup); });

Comment 3

[Sevaan Franks [:sevaan]]

(In reply to Ed Lee :Mardak from comment #2)
> If the location bar results are already showing, should they be hidden when
> the user copies?

I think this is reasonable.

Comment 4

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.