test_autofill_password-only.html fails on Android when running ONLY the passwordmgr mochitests.

RESOLVED FIXED in Firefox 51

Status

()

Toolkit
Password Manager
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Dolske, Assigned: MattN)

Tracking

unspecified
mozilla51
All
Android
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [passwords:tech-debt])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Spinning off from bug 1267388 comment 17 - 19.

I was doing a try push, and was getting repeatable failures in an unrelated test on Android. An empty try push running just the pwmgr tests also fails, so this is an existing issue. AFAIK this isn't happening on the normal trees (inbound, m-c, etc), so this seems to only happen when tests are run this way. Dunno why!

I reproduced this with "mach try -b do -p android-api-15 toolkit/components/passwordmgr/test/mochitest/"

Other tests in the directory complete successfully. Of potential note is that this is the first test that runs in the dir. (Might be worth changing the order to see if that matters?)

MattN mentioned bug 1259768 as vaguely similar. May or may not be related.
Whiteboard: [passwords:tech-debt]
I think the problem here is that LoginManagerParent.init is delayed quite a bit on Android and so when running the directory it hasn't run by the time it's needed. I'm looking into a possible fix in https://treeherder.mozilla.org/#/jobs?repo=try&revision=875f4f329b7b630802afe3e23c9f70cf0434978b which is to call init in setupParent.
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
OS: Unspecified → Android
Hardware: Unspecified → All
Created attachment 8777092 [details]
Bug 1267849 - Call LoginManagerParent.init in setupParent of tests.

Review commit: https://reviewboard.mozilla.org/r/68682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68682/
Attachment #8777092 - Flags: review?(dolske)
Comment on attachment 8777092 [details]
Bug 1267849 - Call LoginManagerParent.init in setupParent of tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68682/diff/1-2/
(Reporter)

Comment 5

2 years ago
Comment on attachment 8777092 [details]
Bug 1267849 - Call LoginManagerParent.init in setupParent of tests.

https://reviewboard.mozilla.org/r/68682/#review66126
Attachment #8777092 - Flags: review?(dolske) → review+

Comment 6

2 years ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/fx-team/rev/69b0f784a9a2
Call LoginManagerParent.init in setupParent of tests. r=dolske

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/69b0f784a9a2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.