Closed Bug 1267889 Opened 9 years ago Closed 9 years ago

Always steal the error result in `PushMessage::Json`

Categories

(Core :: DOM: Push Subscriptions, defect)

Product:
Core
Component:
DOM: Push Subscriptions
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: lina, Assigned: lina)

References

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

stealJSONErrors.patch
3.38 KB, patch
dragana
: review+
Details | Diff | Splinter Review
Otherwise, we'll trip this assertion in ErrorResult, even if ConsumeJson doesn't throw any JS exceptions: https://dxr.mozilla.org/mozilla-central/rev/fc15477ce628599519cb0055f52cc195d640dc94/dom/bindings/ErrorResult.h#102-103,105
Attachment #8745802 - Flags: review?(dd.mozilla)
Blocks: 1201335
Attachment #8745802 - Flags: review?(dd.mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/edf0a830c947
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: