Closed
Bug 1267912
Opened 8 years ago
Closed 8 years ago
Rename nsNetUtil.inl as nsNetUtilInlines.h
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
|
2.25 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
Multiple times now I've been tricked by the fact that nsNetUtil.inl is actually C++ code. E.g. if you look for a code pattern through all .h and .cpp files, you'll miss ones that occur in this file. There's a precedent in layout/ of using a "Inlines.h" suffix for this kind of file, which I propose we adopt for this file.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8745845 -
Flags: review?(valentin.gosu)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8745845 [details] [diff] [review] Rename nsNetUtil.inl as nsNetUtilInlines.h Looks good. Thanks!
Attachment #8745845 -
Flags: review?(valentin.gosu) → review+
|
|
||
Updated•8 years ago
|
Whiteboard: [necko-active]
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/28f944410c7fdf27f7ddf16fc01be4eb0a6eade8 Bug 1267912 - Rename nsNetUtil.inl as nsNetUtilInlines.h. r=valentin.
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/28f944410c7f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•