1267913 - Windows AWS instances come up with nothing in hg-shared

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

I've checked this by looking at the first job a machine does on try, and also by inspecting y-2008-spot and b-2008-spot instances just after they come up - c:\builds\hg-shared is empty, despite all the effort to populate it.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

grenade, am I following the code correctly here .....

It looks like we populate hg-shared with Get-SourceCaches at
 https://github.com/mozilla/build-cloud-tools/blob/master/configs/b-2008.user-data#L114
and then blow them away again inside Prep-Golden with Flush-BuildFiles at
 https://github.com/mozilla/build-cloud-tools/blob/master/configs/Ec2UserdataUtils.psm1#L845

Do you recall if there is some reason for this ordering, or perhaps things got re-arranged at some point and we missed the regression ?

Comment 2

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: https://github.com/mozilla/build-cloud-tools/pull/212

nthomas++
thanks for the debugging!
pr submitted

Comment 3

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Comment on attachment 8748625 [details] [review]
https://github.com/mozilla/build-cloud-tools/pull/212

pr merged