Closed Bug 126793 Opened 18 years ago Closed 18 years ago

Templatise showdependencygraph.cgi

Categories

(Bugzilla :: Bugzilla-General, defect, blocker)

2.15
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: gerv, Assigned: gerv)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

As above.

Gerv
Target Milestone: --- → Bugzilla 2.16
Gerv, this won't be trivial because currently the html is generated before the
hide_resolved&maxdepth toolbar is displayed, but displayed afterwards.

Of course it would be nice to have everything templatized, but are you sure that
showdependency{tree,graph}.cgi are really _blockers_ for 2.16?

If you are doing it anyway, you could build an array (or tree) of hashes instead
of the html. Every hash could have information about a single line (= bug).
It is a blocker because it's user-facing. We should not be relaxing out criteria
for what we templatise any more than we have.

Take heart! All the templatisation bugs are now filed. There are no more hidden
surprises.

Gerv
Swapping titles due to misattachment of patch over in bug 126792..

Gerv
Summary: Templatise showdependencytree.cgi → Templatise showdependencygraph.cgi
I've begun this, but can't go on until the local dot patch is checked in (bug
120537).

Gerv
Depends on: 120537
The fix for bug 120537 has been checked in.  Don't delay, post the code today!
Attached patch Patch v.1 (obsolete) — Splinter Review
Here's version 1. Let me know what you think :-) 

Gerv
Blocks: 134565
Comment on attachment 77228 [details] [diff] [review]
Patch v.1

Index: showdependencygraph.cgi

>-graph [URL="${urlbase}query.cgi", rankdir=$::FORM{'rankdir'}, size="64,64"]
>-node [URL="${urlbase}show_bug.cgi?id=\\N", style=filled, color=lightgrey]

>+graph [URL="query.cgi", rankdir=$::FORM{'rankdir'}, size="64,64"]
>+node [URL="show_bug.cgi?id=\\N", style=filled, color=lightgrey]

I think URLBASE is required here because the URLs load from a link on 
the AT&T research site.
Attachment #77228 - Flags: review-
Attached patch Patch v.2Splinter Review
Fixed Myk's comment.

Gerv
Attachment #77228 - Attachment is obsolete: true
Comment on attachment 77479 [details] [diff] [review]
Patch v.2

Looks good, works. r=myk
Attachment #77479 - Flags: review+
Comment on attachment 77479 [details] [diff] [review]
Patch v.2

>+      <td>
>+        Bug numbers:
>+        <input name="id" value="[% bug_id FILTER html %]">
>+      </td>

You don't need to html filter number + comma.

r=bbaetz apart from that, tested with a local dot binary.
Attachment #77479 - Flags: review+
but it doesn't hurt anything, either, and it looks safer to a code auditor.
-> patch author

(this is ready for checkin, btw)
Assignee: justdave → gerv
Keywords: patch
No, it looks like 'why are you filtering a number? Can this not be a number?'
etc, etc.

It won't make a difference, and it will be (very slightly) quicker not to filter.
Fixed.

Checking in showdependencygraph.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v  <-- 
showdependencygraph.cgi
new revision: 1.15; previous revision: 1.14
done
RCS file:
/cvsroot/mozilla/webtools/bugzilla/template/default/show/dependency-graph.html.tmpl,v
done
Checking in template/default/show/dependency-graph.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/default/show/dependency-graph.html.tmpl,v
 <--  dependency-graph.html.tmpl
initial revision: 1.1
done

Gerv
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Blocks: 355728
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.