1267936 - Ensure no MediaDecoder is created when MediaShutdownManager::Shutdown() begins

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

I suspect some shutdown hang bugs are resulted from this. 

https://hg.mozilla.org/mozilla-central/file/fc15477ce628599519cb0055f52cc195d640dc94/dom/media/MediaShutdownManager.cpp#l52
Let's make it a stronger assertion to catch the problem in release builds.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=213d7ab0a4fb

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1267936 - make a stronger assertion to catch that MediaDecoder is created when MediaShutdownManager::Shutdown() begins. r=jya.

Review commit: https://reviewboard.mozilla.org/r/49593/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49593/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8746892 [details]
MozReview Request: Bug 1267936 - make a stronger assertion to catch that MediaDecoder is created when MediaShutdownManager::Shutdown() begins. r=jya.

https://reviewboard.mozilla.org/r/49593/#review46391

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d6b28fdf915

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9d6b28fdf915

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8746892 [details]
MozReview Request: Bug 1267936 - make a stronger assertion to catch that MediaDecoder is created when MediaShutdownManager::Shutdown() begins. r=jya.

Approval Request Comment
[Feature/regressing bug #]:none
[User impact if declined]:none
[Describe test coverage new/current, TreeHerder]:TreeHerder
[Risks and why]: Very low. This patch changes a MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to allow us to catch abnormal activities in Aurora/Nightly on non-debug builds. Beta and beyond will not be affected at all.
[String/UUID change made/needed]:none

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8746892 [details]
MozReview Request: Bug 1267936 - make a stronger assertion to catch that MediaDecoder is created when MediaShutdownManager::Shutdown() begins. r=jya.

Improve crash diagnostic, please uplift to aurora

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cf28b66d7412