Closed
Bug 1267936
Opened 8 years ago
Closed 8 years ago
Ensure no MediaDecoder is created when MediaShutdownManager::Shutdown() begins
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
jya
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
I suspect some shutdown hang bugs are resulted from this. https://hg.mozilla.org/mozilla-central/file/fc15477ce628599519cb0055f52cc195d640dc94/dom/media/MediaShutdownManager.cpp#l52 Let's make it a stronger assertion to catch the problem in release builds.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jwwang
Version: 47 Branch → unspecified
Assignee | ||
Comment 1•8 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=213d7ab0a4fb
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49593/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49593/
Attachment #8746892 -
Flags: review?(jyavenard)
Updated•8 years ago
|
Attachment #8746892 -
Flags: review?(jyavenard) → review+
Comment 3•8 years ago
|
||
Comment on attachment 8746892 [details] MozReview Request: Bug 1267936 - make a stronger assertion to catch that MediaDecoder is created when MediaShutdownManager::Shutdown() begins. r=jya. https://reviewboard.mozilla.org/r/49593/#review46391
Assignee | ||
Comment 4•8 years ago
|
||
Thanks!
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9d6b28fdf915
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8746892 [details] MozReview Request: Bug 1267936 - make a stronger assertion to catch that MediaDecoder is created when MediaShutdownManager::Shutdown() begins. r=jya. Approval Request Comment [Feature/regressing bug #]:none [User impact if declined]:none [Describe test coverage new/current, TreeHerder]:TreeHerder [Risks and why]: Very low. This patch changes a MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to allow us to catch abnormal activities in Aurora/Nightly on non-debug builds. Beta and beyond will not be affected at all. [String/UUID change made/needed]:none
Attachment #8746892 -
Flags: approval-mozilla-aurora?
Comment 8•8 years ago
|
||
Comment on attachment 8746892 [details] MozReview Request: Bug 1267936 - make a stronger assertion to catch that MediaDecoder is created when MediaShutdownManager::Shutdown() begins. r=jya. Improve crash diagnostic, please uplift to aurora
Attachment #8746892 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/cf28b66d7412
status-firefox48:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•