Closed Bug 1267936 Opened 6 years ago Closed 6 years ago

Ensure no MediaDecoder is created when MediaShutdownManager::Shutdown() begins

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

I suspect some shutdown hang bugs are resulted from this. 

https://hg.mozilla.org/mozilla-central/file/fc15477ce628599519cb0055f52cc195d640dc94/dom/media/MediaShutdownManager.cpp#l52
Let's make it a stronger assertion to catch the problem in release builds.
Assignee: nobody → jwwang
Version: 47 Branch → unspecified
Blocks: 1267933
Attachment #8746892 - Flags: review?(jyavenard) → review+
Comment on attachment 8746892 [details]
MozReview Request: Bug 1267936 - make a stronger assertion to catch that MediaDecoder is created when MediaShutdownManager::Shutdown() begins. r=jya.

https://reviewboard.mozilla.org/r/49593/#review46391
Thanks!
https://hg.mozilla.org/mozilla-central/rev/9d6b28fdf915
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment on attachment 8746892 [details]
MozReview Request: Bug 1267936 - make a stronger assertion to catch that MediaDecoder is created when MediaShutdownManager::Shutdown() begins. r=jya.

Approval Request Comment
[Feature/regressing bug #]:none
[User impact if declined]:none
[Describe test coverage new/current, TreeHerder]:TreeHerder
[Risks and why]: Very low. This patch changes a MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to allow us to catch abnormal activities in Aurora/Nightly on non-debug builds. Beta and beyond will not be affected at all.
[String/UUID change made/needed]:none
Attachment #8746892 - Flags: approval-mozilla-aurora?
Comment on attachment 8746892 [details]
MozReview Request: Bug 1267936 - make a stronger assertion to catch that MediaDecoder is created when MediaShutdownManager::Shutdown() begins. r=jya.

Improve crash diagnostic, please uplift to aurora
Attachment #8746892 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.