Closed Bug 1267958 Opened 4 years ago Closed 4 years ago
Crash Annotation Graphics
Critical Error: |[GFX1-]: Clear Rect with invalid argument 0x0x7fbca8580000 with 0x0 [0, 0]
When visting nytimes.com today I got a bunch of Crash Annotation GraphicsCriticalError: |[GFX1-]: ClearRect with invalid argument 0x0x7fbca8580000 with 0x0 [0, 0][GFX1-]: ClearRect with invalid argument 0x0x7fbca8580000 with 0x0 [0, 0] messages in my console. This happens with a vanilla Firefox 45 which Debian ships. Looking a bit with Tor Browser it seems disabling content SVG avoids this. The culprit is the interactive map showing the detailed results of the republican/democrats election.
I think we should probably loosen this check to accept 0x0 rectangles. Cairo should be handling them just fine. We should also try to get a test case that triggers this behaviour. Georg, is it possible for you to save the page and reproduce this with the saved copy?
Good idea. (I should have thought of that earlier :) ) The saved copy is attached and, yes, I was able to reproduce the problem with it.
Review commit: https://reviewboard.mozilla.org/r/49247/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49247/
Attachment #8746073 - Flags: review?(jmuizelaar)
Yeah, don't need to worry about zeros.
Assignee: nobody → milan
Comment on attachment 8746073 [details] MozReview Request: Bug 1267958: Only complain for negative size, not merely zero. r?jrmuizel https://reviewboard.mozilla.org/r/49247/#review46155
Attachment #8746073 - Flags: review?(jmuizelaar) → review+
You need to log in before you can comment on or make changes to this bug.