Closed
Bug 1267958
Opened 6 years ago
Closed 6 years ago
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: ClearRect with invalid argument 0x0x7fbca8580000 with 0x0 [0, 0]
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: gk, Assigned: milan)
Details
(Whiteboard: [gfx-noted])
Attachments
(2 files)
When visting nytimes.com today I got a bunch of Crash Annotation GraphicsCriticalError: |[0][GFX1-]: ClearRect with invalid argument 0x0x7fbca8580000 with 0x0 [0, 0][GFX1-]: ClearRect with invalid argument 0x0x7fbca8580000 with 0x0 [0, 0] messages in my console. This happens with a vanilla Firefox 45 which Debian ships. Looking a bit with Tor Browser it seems disabling content SVG avoids this. The culprit is the interactive map showing the detailed results of the republican/democrats election.
Comment 1•6 years ago
|
||
I think we should probably loosen this check to accept 0x0 rectangles. Cairo should be handling them just fine. We should also try to get a test case that triggers this behaviour. Georg, is it possible for you to save the page and reproduce this with the saved copy?
Flags: needinfo?(gk)
Updated•6 years ago
|
Flags: needinfo?(milan)
Reporter | ||
Comment 2•6 years ago
|
||
Good idea. (I should have thought of that earlier :) ) The saved copy is attached and, yes, I was able to reproduce the problem with it.
Assignee | ||
Comment 3•6 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49247/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49247/
Attachment #8746073 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 4•6 years ago
|
||
Yeah, don't need to worry about zeros.
Assignee: nobody → milan
Flags: needinfo?(milan)
Whiteboard: [gfx-noted]
Comment 5•6 years ago
|
||
Comment on attachment 8746073 [details] MozReview Request: Bug 1267958: Only complain for negative size, not merely zero. r?jrmuizel https://reviewboard.mozilla.org/r/49247/#review46155
Attachment #8746073 -
Flags: review?(jmuizelaar) → review+
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5e9db56271f4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(gk)
You need to log in
before you can comment on or make changes to this bug.
Description
•