1267958 - Crash Annotation GraphicsCriticalError: |[0][GFX1-]: ClearRect with invalid argument 0x0x7fbca8580000 with 0x0 [0, 0]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Georg Koppen]

When visting nytimes.com today I got a bunch of 

Crash Annotation GraphicsCriticalError: |[0][GFX1-]: ClearRect with invalid argument 0x0x7fbca8580000 with 0x0 [0, 0][GFX1-]: ClearRect with invalid argument 0x0x7fbca8580000 with 0x0 [0, 0]

messages in my console. This happens with a vanilla Firefox 45 which Debian ships. Looking a bit with Tor Browser it seems disabling content SVG avoids this. The culprit is the interactive map showing the detailed results of the republican/democrats election.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

I think we should probably loosen this check to accept 0x0 rectangles. Cairo should be handling them just fine. We should also try to get a test case that triggers this behaviour.

Georg, is it possible for you to save the page and reproduce this with the saved copy?

Comment 2

[Georg Koppen]

Attachment: NYTimes website triggering the crash annotation

Good idea. (I should have thought of that earlier :) ) The saved copy is attached and, yes, I was able to reproduce the problem with it.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: MozReview Request: Bug 1267958: Only complain for negative size, not merely zero. r?jrmuizel

Review commit: https://reviewboard.mozilla.org/r/49247/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49247/

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Yeah, don't need to worry about zeros.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8746073 [details]
MozReview Request: Bug 1267958: Only complain for negative size, not merely zero. r?jrmuizel

https://reviewboard.mozilla.org/r/49247/#review46155

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e9db56271f4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e9db56271f4