126797 - Undo/Redo doesn't work in Text widgets, Composer, and Mail

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[kinmoz]

Some nsDeque changes landed last night and one of the changes made to
nsTransactionStack.cpp prevents undo/redo from working.

I have a patch that fixes undo, but redo is not working at the moment, still
investigating.

Comment 1

[kinmoz]

The nsDeque changes I was referring to were for bug 114166.

Comment 2

[kinmoz]

Attachment: Patch Rev 1

nsTransactionStack::Peek() was intended to return NULL for an empty stack so I
changed timeless' change to return NS_OK and init the return value to zero.

timeless also changed the behavior of nsDeque::End(), it no longer returns an
interator that is one past the end. So nsTransactionStack::Peek() had to call
CurrentItem() instead of operator--.

I also backed out the changes to nsTransactionManager.cpp cause they are
unnecessary with the changes made to nsTransactionStack::Peek().

Comment 3

[kinmoz]

Comment on attachment 70596 [details] [diff] [review]
Patch Rev 1

r=[e-mail]
sr=[e-mail]
a=[e-mail]

Comment 4

[kinmoz]

Fix checked into TRUNK:

  mozilla/editor/txmgr/src/nsTransactionManager.cpp rev 1.38
  mozilla/editor/txmgr/src/nsTransactionStack.cpp   rev 1.18

Comment 5

[kinmoz]

Really marking FIXED.

Comment 6

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2003.04.03. tested with html input fields, mail compose and
composer.