1268148 - Addon compartments in child processes not grouped under add-ons category

Status: UNCONFIRMED

(Toolkit :: about:memory, defect, P3)

Description

[The 8472]

I'm seeing addon JSMs loaded through a framescript (i.e. loaded through addon main -> framescript -> JSM) properly categorized in the add-ons category in the parent process. The same JSM is just lumped under the top-level js-non-window category in the child process.

Comment 1

[Nicholas Nethercote [inactive]]

Nils, any idea why this might be happening, and how to fix it?

Comment 2

[Eric Rahm [:erahm]]

This is split out by the XPCJSRuntime ReportCompartmentStats function [1]. It will report the compartment under 'explicit/add-ons' if the following conditions are met:

- extras.location is not null (this is a URI)
- addonManager is not null
- extras.jsPathPrefix does not already start with 'add-ons'
- addonManager->MapURIToAddonID must not fail

So presumably one of these conditions is not met in the content process.

[1] https://dxr.mozilla.org/mozilla-central/rev/6adc822f5e27a55551faeb6c47a9bd8b0859a23b/js/xpconnect/src/XPCJSRuntime.cpp#2258-2275

Comment 3

[Eric Rahm [:erahm]]

Looks like the call to |addonManager->MapURIToAddonID| is failing. If I'm reading correctly the AddonManager is implemented in js, the jsm indicates it shouldn't be used from the child process [1].

[1] https://dxr.mozilla.org/mozilla-central/rev/6adc822f5e27a55551faeb6c47a9bd8b0859a23b/toolkit/mozapps/extensions/AddonManager.jsm#20

Comment 4

[Nicholas Nethercote [inactive]]

Thank you for looking at this.

> Looks like the call to |addonManager->MapURIToAddonID| is failing. If I'm
> reading correctly the AddonManager is implemented in js, the jsm indicates
> it shouldn't be used from the child process [1].

Ugh, so presumably we'd have to send a message to the parent process to get this info. That's no fun.

Comment 5

[Eric Rahm [:erahm]]

(In reply to Nicholas Nethercote [:njn] from comment #4)
> Thank you for looking at this.
> 
> > Looks like the call to |addonManager->MapURIToAddonID| is failing. If I'm
> > reading correctly the AddonManager is implemented in js, the jsm indicates
> > it shouldn't be used from the child process [1].
> 
> Ugh, so presumably we'd have to send a message to the parent process to get
> this info. That's no fun.

The other problem is it's called on every compartment that has a URI. If the call succeeds then we know it's an add-on compartment, so that would mean proxying a call for each compartment.

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:edgar, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 20

[Handyman Services]

Hi Friends,

Are you searching <a href="https://atdoorstep.ae/dubai/handyman">handyman services near me</a>. Don't worry, Atdoorstep provide the best handyman services for your home repair & home maintenance services.