[FIX]Background doesn't paint the correct rect

VERIFIED FIXED in mozilla0.9.9

Status

()

VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: dcone, Assigned: rods)

Tracking

Trunk
mozilla0.9.9
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.24 KB, patch
dcone
: review+
attinasi
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

17 years ago
The background drawing code is in the wrong frame currently, needs to be moved
so that it is not offset.

Also.. it should only draw once.. with the background paint.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: nsbeta1
Target Milestone: --- → mozilla0.9.9
(Assignee)

Updated

17 years ago
Summary: Move the drawbackground from nsPageFrame to nsPageContentFrame → Background doesn't paint the correct rect
(Assignee)

Comment 1

17 years ago
Created attachment 70604 [details] [diff] [review]
patch

Low risk - Get the rect of the PageContentFrame and using it. Also, painting BG
after the container and only when we are suppose to be painting the BG
(Reporter)

Comment 2

17 years ago
Comment on attachment 70604 [details] [diff] [review]
patch

r=dcone
Attachment #70604 - Flags: review+
(Assignee)

Comment 3

17 years ago
Created attachment 70609 [details] [diff] [review]
better patch

After discussing this with don the BG should be painted before going to the
PageContentFrame, in case any of its children need to paint a BG.
Attachment #70604 - Attachment is obsolete: true
(Reporter)

Comment 4

17 years ago
Comment on attachment 70609 [details] [diff] [review]
better patch

r=dcone
Attachment #70609 - Flags: review+
Marking nsbeta1+.  This is a highly visible issue. I noticed this bug right away
when I turned on printing background colors and went into print-preview. 
Keywords: nsbeta1 → nsbeta1+
(Assignee)

Updated

17 years ago
Summary: Background doesn't paint the correct rect → [FIX]Background doesn't paint the correct rect

Comment 6

17 years ago
Comment on attachment 70609 [details] [diff] [review]
better patch

sr=attinasi
Attachment #70609 - Flags: superreview+
a=dbaron for attachment 70609 [details] [diff] [review] for mozilla0.9.9
Keywords: mozilla0.9.9+
(Assignee)

Comment 8

17 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 9

17 years ago
Rod/Don, can one of you verify this bug ? thanks...mark it verified-fixed also..

(Reporter)

Comment 10

17 years ago
Paints in teh correct spot.  Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.