1268242 - "Verified" button's link in the Autoclassify panel should open into a new tab.

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

At the moment, if I click to save an autoclassification, the "Save" button changes to "Verified". If I click that "Verified" button, it opens the current page to https://treeherder.mozilla.org/failureviewer.html#/?classified_failure_id=<ID>

It should open into a new tab so it doesn't take me away from Treeherder.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The "Other matching failures..." link already opens a new tab, as it should, so this would just be to get the Verified button to do the same thing.

Comment 2

[James Graham [:jgraham]]

Should be easy to fix, just add target=_blank to the relevant link. I can do it, but patches are also accepted ;)

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:open_link_new_window > mozilla:master

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8767225 [details] [review]
[treeherder] mozilla:open_link_new_window > mozilla:master

Easiest. Review. Ever.  :)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f530816dbd9d8610bb9e0e1aae431405147e1354
Bug 1268242 - Open all links from autoclassification panel in new window/tab (#1641)