Closed Bug 1268290 Opened 4 years ago Closed 4 years ago

stylo: Pass correct stylesheet origin to Servo

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: emilio, Unassigned)

References

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
Attached patch Proposed patch (obsolete) — Splinter Review
Attachment #8746275 - Flags: review?(bobbyholley)
Comment on attachment 8746275 [details] [diff] [review]
Proposed patch

Review of attachment 8746275 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/ServoBindings.h
@@ +66,5 @@
>  //
>  // TODO: Make these return already_AddRefed and UniquePtr when the binding
>  // generator is smart enough to handle them.
> +RawServoStyleSheet* Servo_StylesheetFromUTF8Bytes(const uint8_t* bytes, uint32_t length,
> +    mozilla::css::SheetParsingMode parsing_mode);

Nit: indent this to the open-paren.
Attachment #8746275 - Flags: review?(bobbyholley) → review+
Attached patch Patch with nit addressed (obsolete) — Splinter Review
Attachment #8746275 - Attachment is obsolete: true
Attachment #8746276 - Flags: review?(bobbyholley)
Attachment #8746276 - Flags: review?(bobbyholley) → review+
Comment on attachment 8746276 [details] [diff] [review]
Patch with nit addressed

Oops - you'll need to fix the stub to prevent compilation from failing on non-stylo builds.
Attachment #8746276 - Flags: review+ → review-
Attachment #8746276 - Attachment is obsolete: true
Comment on attachment 8746282 [details] [diff] [review]
Patch with correct function stubbed

Should be good to go.
Attachment #8746282 - Flags: review?(bobbyholley)
Comment on attachment 8746282 [details] [diff] [review]
Patch with correct function stubbed

Review of attachment 8746282 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/ServoBindings.cpp
@@ +215,4 @@
>  }
>  
>  #include "nsStyleStructList.h"
> +#include "mozilla/css/SheetParsingMode.h"

This isn't needed given that it gets included via ServoBindings.h right?
Attachment #8746282 - Flags: review?(bobbyholley) → review+
(In reply to Bobby Holley (busy) from comment #7)
> >  #include "nsStyleStructList.h"
> > +#include "mozilla/css/SheetParsingMode.h"
> 
> This isn't needed given that it gets included via ServoBindings.h right?

Yep, you're right. Also, it was in an uncommon place, removed.
Attached patch Final versionSplinter Review
Attachment #8746282 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/dc4b21ccd9c0
https://hg.mozilla.org/mozilla-central/rev/d928d2fde8c7
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.