1268290 - stylo: Pass correct stylesheet origin to Servo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Proposed patch

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8746275 [details] [diff] [review]
Proposed patch

Review of attachment 8746275 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/ServoBindings.h
@@ +66,5 @@
>  //
>  // TODO: Make these return already_AddRefed and UniquePtr when the binding
>  // generator is smart enough to handle them.
> +RawServoStyleSheet* Servo_StylesheetFromUTF8Bytes(const uint8_t* bytes, uint32_t length,
> +    mozilla::css::SheetParsingMode parsing_mode);

Nit: indent this to the open-paren.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Patch with nit addressed

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8746276 [details] [diff] [review]
Patch with nit addressed

Oops - you'll need to fix the stub to prevent compilation from failing on non-stylo builds.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Patch with correct function stubbed

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8746282 [details] [diff] [review]
Patch with correct function stubbed

Should be good to go.

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 8746282 [details] [diff] [review]
Patch with correct function stubbed

Review of attachment 8746282 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/ServoBindings.cpp
@@ +215,4 @@
>  }
>  
>  #include "nsStyleStructList.h"
> +#include "mozilla/css/SheetParsingMode.h"

This isn't needed given that it gets included via ServoBindings.h right?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

(In reply to Bobby Holley (busy) from comment #7)
> >  #include "nsStyleStructList.h"
> > +#include "mozilla/css/SheetParsingMode.h"
> 
> This isn't needed given that it gets included via ServoBindings.h right?

Yep, you're right. Also, it was in an uncommon place, removed.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Final version

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc4b21ccd9c0

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d928d2fde8c7

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dc4b21ccd9c0
https://hg.mozilla.org/mozilla-central/rev/d928d2fde8c7