"ruby-align: space-around" behaves like "start" if the ruby base has only one combined-text.

RESOLVED FIXED in Firefox 49

Status

()

Core
Layout: Text
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: baba, Assigned: xidorn)

Tracking

49 Branch
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(6 attachments)

(Reporter)

Description

2 years ago
Created attachment 8746362 [details]
text-combine-ruby.html

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.87 Safari/537.36

Steps to reproduce:

Open attached HTML.

- <ruby> has a <rb> and a <rt>
- "text-combine-upright:all" is applied to <rb>
- <rt> contains a long text.


Actual results:

The combined text, the contents of <rb>, is aligned to top of the ruby container.


Expected results:

The combined text, the contents of <rb>, should be placed to vertical-center of the ruby container.
(Reporter)

Comment 1

2 years ago
Created attachment 8746363 [details]
expected_result.png

Updated

2 years ago
Component: Untriaged → Layout: Text
Product: Firefox → Core
(Assignee)

Updated

2 years ago
Assignee: nobody → bugzilla
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 2

2 years ago
Created attachment 8757088 [details]
MozReview Request: Bug 1268342 part 1 - Remove useless constructor of PerFrameData. r?jfkthame

Review commit: https://reviewboard.mozilla.org/r/55608/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55608/
Attachment #8757088 - Flags: review?(jfkthame)
Attachment #8757089 - Flags: review?(jfkthame)
Attachment #8757090 - Flags: review?(jfkthame)
Attachment #8757091 - Flags: review?(jfkthame)
(Assignee)

Comment 3

2 years ago
Created attachment 8757089 [details]
MozReview Request: Bug 1268342 part 2 - Store writing mode of frame in PerFrameData. r?jfkthame

Review commit: https://reviewboard.mozilla.org/r/55610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55610/
(Assignee)

Comment 4

2 years ago
Created attachment 8757090 [details]
MozReview Request: Bug 1268342 part 3 - Treat orthogonal text frame as non-text frame when applying justification gap. r?jfkthame

Also correct the comment in ComputeJustification.

Review commit: https://reviewboard.mozilla.org/r/55612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55612/
(Assignee)

Comment 5

2 years ago
Created attachment 8757091 [details]
MozReview Request: Bug 1268342 part 4 - Add reftest for ruby with text-combine-upright. r?jfkthame

Review commit: https://reviewboard.mozilla.org/r/55614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55614/
Comment on attachment 8757088 [details]
MozReview Request: Bug 1268342 part 1 - Remove useless constructor of PerFrameData. r?jfkthame

https://reviewboard.mozilla.org/r/55608/#review52712
Attachment #8757088 - Flags: review?(jfkthame) → review+
Attachment #8757089 - Flags: review?(jfkthame) → review+
Comment on attachment 8757089 [details]
MozReview Request: Bug 1268342 part 2 - Store writing mode of frame in PerFrameData. r?jfkthame

https://reviewboard.mozilla.org/r/55610/#review52714
Comment on attachment 8757090 [details]
MozReview Request: Bug 1268342 part 3 - Treat orthogonal text frame as non-text frame when applying justification gap. r?jfkthame

https://reviewboard.mozilla.org/r/55612/#review52716

::: layout/generic/nsTextFrame.cpp:3078
(Diff revision 1)
> -  // U+FFFC, which indicates it is justifiable on its sides, we don't
> -  // do that because it is difficult to implement, and doesn't make
> +  // do not insert justification opportunities on sides of that char,
> +  // sides of this frame is not justifiable either.

comment nit:
  s/on sides/on the sides/
  s/sides...is/the sides...are/
Attachment #8757090 - Flags: review?(jfkthame) → review+
Comment on attachment 8757091 [details]
MozReview Request: Bug 1268342 part 4 - Add reftest for ruby with text-combine-upright. r?jfkthame

https://reviewboard.mozilla.org/r/55614/#review52718
Attachment #8757091 - Flags: review?(jfkthame) → review+
(Assignee)

Comment 10

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d36ad40cf9910c695a20eff674aa18dc89d3b269
Bug 1268342 part 1 - Remove useless constructor of PerFrameData. r=jfkthame

https://hg.mozilla.org/integration/mozilla-inbound/rev/77af17d7575646053e3ffad7c2f8c19e675e866e
Bug 1268342 part 2 - Store writing mode of frame in PerFrameData. r=jfkthame

https://hg.mozilla.org/integration/mozilla-inbound/rev/7beb1565767200b49de2450912af5624ab7f4725
Bug 1268342 part 3 - Treat orthogonal text frame as non-text frame when applying justification gap. r=jfkthame

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d7674be600defa53a0721874b75731d56c09fc7
Bug 1268342 part 4 - Add reftest for ruby with text-combine-upright. r=jfkthame

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d36ad40cf991
https://hg.mozilla.org/mozilla-central/rev/77af17d75756
https://hg.mozilla.org/mozilla-central/rev/7beb15657672
https://hg.mozilla.org/mozilla-central/rev/0d7674be600d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.