1268373 - r? also when all the patches have the "ship it" flag

Status: RESOLVED DUPLICATE of bug 1248996

(MozReview Graveyard :: General, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: foo.png

Check the attachment. I reviewed all the patches, as you can see, but the UI shows a 'r?' box for each one of them. Also the tooltip says the the patch is in a kind of pending review state.
But as you can also see, at the bottom of the page, the patch has the 'ship it' green flag.
I'm confused. It seems a bug in the UI.

Comment 1

[:glob ✱]

this is happening because even though you have level 3 commit access, you haven't associated you ldap account with your mozreview account.  so while there's a "ship it", it isn't from anyone mozreview thinks is _suitable_.

this association happens automatically when you push a review.

you can do this manually by following http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#manually-associating-your-ldap-account-with-mozreview