Closed Bug 1268390 Opened 5 years ago Closed 5 years ago

add support for doc style sheets in ServoStyleSet

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(3 files)

No description provided.
Blocks: stylo
Comment on attachment 8746438 [details] [diff] [review]
Part 1: Factor out most of nsStyleSet::AddDocStyleSheet for re-use.

Review of attachment 8746438 [details] [diff] [review]:
-----------------------------------------------------------------

r=me modulo those fixes.

::: dom/base/nsIDocumentInlines.h
@@ +51,5 @@
> +      mozilla::StyleSheetHandle authorSheet = GetFirstAdditionalAuthorSheet();
> +      MOZ_ASSERT(!authorSheet ||
> +                 authorSheet->IsGecko() ==
> +                   mozilla::StyleSheetHandle(aSheet)->IsGecko(),
> +                 "why do we have a ServoStyleSheet for an nsStyleSet?");

This assertion should go, right?

::: layout/style/StyleSet.h
@@ +17,5 @@
> +class StyleSet
> +{
> +protected:
> +  template<typename T>
> +  static inline size_t FindDocStyleSheetInsertionPoint(

This appears to live on nsIDocument on the rest of this patch. I assume you changed your mind about adding this file? We'll want it at some point, but should probably remove it for now.
Attachment #8746438 - Flags: review?(bobbyholley) → review+
Attachment #8746439 - Flags: review?(bobbyholley) → review+
Attachment #8746440 - Flags: review?(bobbyholley) → review+
You need to log in before you can comment on or make changes to this bug.