1268390 - add support for doc style sheets in ServoStyleSet

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b1d72ed4d65

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Part 1: Factor out most of nsStyleSet::AddDocStyleSheet for re-use.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Part 2: Add bindings for Servo_InsertStyleSheetBefore.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Part 3: Add support for doc style sheets in ServoStyleSet.

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8746438 [details] [diff] [review]
Part 1: Factor out most of nsStyleSet::AddDocStyleSheet for re-use.

Review of attachment 8746438 [details] [diff] [review]:
-----------------------------------------------------------------

r=me modulo those fixes.

::: dom/base/nsIDocumentInlines.h
@@ +51,5 @@
> +      mozilla::StyleSheetHandle authorSheet = GetFirstAdditionalAuthorSheet();
> +      MOZ_ASSERT(!authorSheet ||
> +                 authorSheet->IsGecko() ==
> +                   mozilla::StyleSheetHandle(aSheet)->IsGecko(),
> +                 "why do we have a ServoStyleSheet for an nsStyleSet?");

This assertion should go, right?

::: layout/style/StyleSet.h
@@ +17,5 @@
> +class StyleSet
> +{
> +protected:
> +  template<typename T>
> +  static inline size_t FindDocStyleSheetInsertionPoint(

This appears to live on nsIDocument on the rest of this patch. I assume you changed your mind about adding this file? We'll want it at some point, but should probably remove it for now.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/750e7e90045e
https://hg.mozilla.org/integration/mozilla-inbound/rev/172901ec8248
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c78dedb9c9

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/750e7e90045e
https://hg.mozilla.org/mozilla-central/rev/172901ec8248
https://hg.mozilla.org/mozilla-central/rev/f5c78dedb9c9