add support for doc style sheets in ServoStyleSet

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

(Blocks: 1 bug)

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Blocks: 1243581
(Assignee)

Comment 2

2 years ago
Created attachment 8746438 [details] [diff] [review]
Part 1: Factor out most of nsStyleSet::AddDocStyleSheet for re-use.
Attachment #8746438 - Flags: review?(bobbyholley)
(Assignee)

Comment 3

2 years ago
Created attachment 8746439 [details] [diff] [review]
Part 2: Add bindings for Servo_InsertStyleSheetBefore.
Attachment #8746439 - Flags: review?(bobbyholley)
(Assignee)

Comment 4

2 years ago
Created attachment 8746440 [details] [diff] [review]
Part 3: Add support for doc style sheets in ServoStyleSet.
Attachment #8746440 - Flags: review?(bobbyholley)
Comment on attachment 8746438 [details] [diff] [review]
Part 1: Factor out most of nsStyleSet::AddDocStyleSheet for re-use.

Review of attachment 8746438 [details] [diff] [review]:
-----------------------------------------------------------------

r=me modulo those fixes.

::: dom/base/nsIDocumentInlines.h
@@ +51,5 @@
> +      mozilla::StyleSheetHandle authorSheet = GetFirstAdditionalAuthorSheet();
> +      MOZ_ASSERT(!authorSheet ||
> +                 authorSheet->IsGecko() ==
> +                   mozilla::StyleSheetHandle(aSheet)->IsGecko(),
> +                 "why do we have a ServoStyleSheet for an nsStyleSet?");

This assertion should go, right?

::: layout/style/StyleSet.h
@@ +17,5 @@
> +class StyleSet
> +{
> +protected:
> +  template<typename T>
> +  static inline size_t FindDocStyleSheetInsertionPoint(

This appears to live on nsIDocument on the rest of this patch. I assume you changed your mind about adding this file? We'll want it at some point, but should probably remove it for now.
Attachment #8746438 - Flags: review?(bobbyholley) → review+
Attachment #8746439 - Flags: review?(bobbyholley) → review+
Attachment #8746440 - Flags: review?(bobbyholley) → review+

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/750e7e90045e
https://hg.mozilla.org/mozilla-central/rev/172901ec8248
https://hg.mozilla.org/mozilla-central/rev/f5c78dedb9c9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.