12684 - xpidl allows [retval] when return type already specified

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P4)

Description

[Michael Ang]

xpidl input:
--
interface foo {
  short bar([retval] out long myRetval);
};
--

Output from xpt_dump:
--
Interface Directory:
   - ::foo (00000000-0000-0000-0000-000000000000):
      Flags:
         Scriptable: FALSE
      Methods:
         uint32 bar(out retval int32, out retval int16);
--

xpt_dump reports that both parameters are marked as being a "retval". Haven't
seen what happens at runtime.

Comment 1

[Michael Ang]

Also, xpidl allows multiple params to be marked with [retval]:

--
interface dual_retval {
  void foo([retval] out short bar, [retval] out short baz);
};
--

xpt_dump output:
--
[..]
      Methods:
         uint32 foo(out retval int16, out retval int16);
[..]
--

Comment 2

[Michael Ang]

Attachment: dual [retval] test case

Comment 3

[Michael Ang]

Attachment: [retval] and method return type test case

Comment 4

[Mike McCabe]

Marking as assigned.  This'd be another check in
xpidl_idl:verify_method_declaration

Comment 5

[Mike Shaver (:shaver emeritus)]

Fix sent to mccabe for review.

Comment 6

[Mike McCabe]

Mostly fixed.  Thanks, shaver.

Detection of this error only occurs in typelib mode, which I worry people might
find annoying, as it'll only occur late in the build after they think their idl
is groovey.

Reassigning to me and lowering priority.

Comment 7

[Mike McCabe]

Fixed with recent checkin.  Thanks, Shaver.