Closed Bug 1268428 Opened 4 years ago Closed 4 years ago

Disable audio down/up sampling when all the constraints have been passed in gUM

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

45 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: padenot, Assigned: padenot)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch WIP patch from vivien (obsolete) — Splinter Review
This is very important for use case other than voice, when using gUM, including, but not limited to, instrument recording, ultrasonic communication...
Comment on attachment 8746467 [details] [diff] [review]
WIP patch from vivien

jesup, that's something I like to have, but I don't know what's missing here.
Attachment #8746467 - Attachment is patch: true
Attachment #8746467 - Flags: feedback?(rjesup)
Paul -- Shall I assign this one to Vivien or you?
Rank: 17
Flags: needinfo?(padenot)
Priority: -- → P1
I can take it.
Assignee: nobody → padenot
Flags: needinfo?(padenot)
Also this can be an issue, because if we add more processing by default, people's app will break, because they won't disable everything. Maybe we should raise this to the WG.
Attachment #8747037 - Flags: review?(rjesup) → review+
Comment on attachment 8747037 [details]
MozReview Request: Bug 1268428 - Use the raw mic data if all the constraints to disable processing have been passed to gUM. r?jesup

https://reviewboard.mozilla.org/r/49687/#review46445
Attachment #8746467 - Attachment is obsolete: true
Attachment #8746467 - Flags: feedback?(rjesup)
https://hg.mozilla.org/mozilla-central/rev/6315f7c5f495
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Blocks: 1271585
You need to log in before you can comment on or make changes to this bug.