1268428 - Disable audio down/up sampling when all the constraints have been passed in gUM

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Paul Adenot (:padenot)]

Attachment: WIP patch from vivien

This is very important for use case other than voice, when using gUM, including, but not limited to, instrument recording, ultrasonic communication...

Comment 1

[Paul Adenot (:padenot)]

Comment on attachment 8746467 [details] [diff] [review]
WIP patch from vivien

jesup, that's something I like to have, but I don't know what's missing here.

Comment 2

[Maire Reavy [:mreavy]]

Paul -- Shall I assign this one to Vivien or you?

Comment 3

[Paul Adenot (:padenot)]

I can take it.

Comment 4

[Paul Adenot (:padenot)]

Also this can be an issue, because if we add more processing by default, people's app will break, because they won't disable everything. Maybe we should raise this to the WG.

Comment 5

[Paul Adenot (:padenot)]

Attachment: MozReview Request: Bug 1268428 - Use the raw mic data if all the constraints to disable processing have been passed to gUM. r?jesup

Review commit: https://reviewboard.mozilla.org/r/49687/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49687/

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8747037 [details]
MozReview Request: Bug 1268428 - Use the raw mic data if all the constraints to disable processing have been passed to gUM. r?jesup

https://reviewboard.mozilla.org/r/49687/#review46445

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6315f7c5f495

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6315f7c5f495