1268449 - [Static Analysis][Resource leak] In function Resolve from ice_unittest.cpp

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P3)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that variable |res| leaks memory in several places:

1.

>>    default:
>>      std::cerr << "Got unexpected address family in DNS lookup: "
>>                << res->ai_family << std::endl;
>>      return "";

2.

>>  if (!strlen(str_addr)) {
>>    std::cerr << "inet_ntop failed" << std::endl;
>>  }
>>
>>  return str_addr;

In both cases we should call freeaddrinfo

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1268449 - prevent memory leak in Resolve. r?ekr

Review commit: https://reviewboard.mozilla.org/r/49441/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49441/

Comment 2

[Eric Rescorla (:ekr)]

Comment on attachment 8746490 [details]
MozReview Request: Bug 1268449 - prevent memory leak in Resolve. r?ekr

https://reviewboard.mozilla.org/r/49441/#review46309

LGTM

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8f4ea4dec60

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c8f4ea4dec60