Closed
Bug 1268458
Opened 9 years ago
Closed 9 years ago
Decouple fronts from highlighter actors.
Categories
(DevTools :: Inspector, defect, P1)
DevTools
Inspector
Tracking
(firefox49 fixed)
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: ejpbruel, Assigned: ejpbruel)
References
Details
Attachments
(2 files, 2 obsolete files)
8.79 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
7.12 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
The inspector actor depends on the highlighter actors, so the latter have to be decoupled before the former.
Assignee | ||
Comment 1•9 years ago
|
||
Carrying over r+ from jryans in bug 1265722.
Attachment #8746495 -
Flags: review+
Assignee | ||
Comment 2•9 years ago
|
||
Carrying over r+ from jryans in bug 1265722.
Attachment #8746496 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8746496 -
Attachment description: patch → Decouple CustomHighlighterFront from HighlighterFront.
Attachment #8746496 -
Attachment is patch: true
Attachment #8746496 -
Attachment mime type: text/x-patch → text/plain
Updated•9 years ago
|
Blocks: 1263289
Status: NEW → ASSIGNED
Iteration: --- → 49.1 - May 9
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [devtools-html]
Assignee | ||
Comment 3•9 years ago
|
||
I had to manually rebase these patches, so I'd like you to take another pass at them. Should just be a rubber stamp review.
Attachment #8746495 -
Attachment is obsolete: true
Attachment #8747732 -
Flags: review?(jryans)
Assignee | ||
Comment 4•9 years ago
|
||
Ditto for this patch.
Attachment #8746496 -
Attachment is obsolete: true
Attachment #8747733 -
Flags: review?(jryans)
Comment on attachment 8747732 [details] [diff] [review]
Decouple HighlighterFront from HighlighterActor.
Review of attachment 8747732 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/shared/specs/highlighters.js
@@ +6,5 @@
> +const {
> + Arg,
> + Option,
> + generateActorSpec
> +} = require("devtools/server/protocol.js");
Just noticed you have added the ".js" extension in `require` in most of your patches... It's optional, and we typically omit it, so let's remove it everywhere that you have added it.
Attachment #8747732 -
Flags: review?(jryans) → review+
Comment on attachment 8747733 [details] [diff] [review]
Decouple CustomHighlighterFront from CustomHighlighterActor.
Review of attachment 8747733 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/client/fronts/highlighters.js
@@ +19,5 @@
> });
>
> exports.HighlighterFront = HighlighterFront;
> +
> +const CustomHighlighterFront = FrontClassWithSpec(customHighlighterSpec, {});
Is it possible to drop the second arg if it's empty?
Attachment #8747733 -
Flags: review?(jryans) → review+
Updated•9 years ago
|
Flags: qe-verify? → qe-verify-
Assignee | ||
Comment 7•9 years ago
|
||
Try push for the patch to decouple HighlighterFront from HighlighterActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d0f55d79d7b
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Assignee | ||
Comment 9•9 years ago
|
||
Try push for the patch to decouple CustomHighlighterFront from CustomHighlighterActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd1e03a837e6
Comment 10•9 years ago
|
||
bugherder |
Updated•9 years ago
|
Iteration: 49.1 - May 9 → 49.2 - May 23
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Comment 12•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•8 years ago
|
Whiteboard: [devtools-html]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•