If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Decouple fronts from highlighter actors.

RESOLVED FIXED in Firefox 49

Status

()

Firefox
Developer Tools: Inspector
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ejpbruel, Assigned: ejpbruel)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 49
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

a year ago
The inspector actor depends on the highlighter actors, so the latter have to be decoupled before the former.
(Assignee)

Comment 1

a year ago
Created attachment 8746495 [details] [diff] [review]
Decouple HighlighterFront from HighlighterActor.

Carrying over r+ from jryans in bug 1265722.
Attachment #8746495 - Flags: review+
(Assignee)

Comment 2

a year ago
Created attachment 8746496 [details] [diff] [review]
Decouple CustomHighlighterFront from HighlighterFront.

Carrying over r+ from jryans in bug 1265722.
Attachment #8746496 - Flags: review+
(Assignee)

Updated

a year ago
Attachment #8746496 - Attachment description: patch → Decouple CustomHighlighterFront from HighlighterFront.
Attachment #8746496 - Attachment is patch: true
Attachment #8746496 - Attachment mime type: text/x-patch → text/plain
Blocks: 1263289
Status: NEW → ASSIGNED
Iteration: --- → 49.1 - May 9
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [devtools-html]
(Assignee)

Comment 3

a year ago
Created attachment 8747732 [details] [diff] [review]
Decouple HighlighterFront from HighlighterActor.

I had to manually rebase these patches, so I'd like you to take another pass at them. Should just be a rubber stamp review.
Attachment #8746495 - Attachment is obsolete: true
Attachment #8747732 - Flags: review?(jryans)
(Assignee)

Comment 4

a year ago
Created attachment 8747733 [details] [diff] [review]
Decouple CustomHighlighterFront from CustomHighlighterActor.

Ditto for this patch.
Attachment #8746496 - Attachment is obsolete: true
Attachment #8747733 - Flags: review?(jryans)
Comment on attachment 8747732 [details] [diff] [review]
Decouple HighlighterFront from HighlighterActor.

Review of attachment 8747732 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/shared/specs/highlighters.js
@@ +6,5 @@
> +const {
> +  Arg,
> +  Option,
> +  generateActorSpec
> +} = require("devtools/server/protocol.js");

Just noticed you have added the ".js" extension in `require` in most of your patches...  It's optional, and we typically omit it, so let's remove it everywhere that you have added it.
Attachment #8747732 - Flags: review?(jryans) → review+
Comment on attachment 8747733 [details] [diff] [review]
Decouple CustomHighlighterFront from CustomHighlighterActor.

Review of attachment 8747733 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/fronts/highlighters.js
@@ +19,5 @@
>  });
>  
>  exports.HighlighterFront = HighlighterFront;
> +
> +const CustomHighlighterFront = FrontClassWithSpec(customHighlighterSpec, {});

Is it possible to drop the second arg if it's empty?
Attachment #8747733 - Flags: review?(jryans) → review+
Flags: qe-verify? → qe-verify-
(Assignee)

Comment 7

a year ago
Try push for the patch to decouple HighlighterFront from HighlighterActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d0f55d79d7b
(Assignee)

Updated

a year ago
Keywords: leave-open

Comment 8

a year ago
https://hg.mozilla.org/integration/fx-team/rev/b041ad17b6c8
(Assignee)

Comment 9

a year ago
Try push for the patch to decouple CustomHighlighterFront from CustomHighlighterActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd1e03a837e6

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b041ad17b6c8
Iteration: 49.1 - May 9 → 49.2 - May 23
(Assignee)

Updated

a year ago
Keywords: leave-open

Comment 11

a year ago
https://hg.mozilla.org/integration/fx-team/rev/52f40a1102ad

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/52f40a1102ad
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Updated

a year ago
Blocks: 1277706

Updated

a year ago
No longer blocks: 1263289
Blocks: 1263289
Whiteboard: [devtools-html]
You need to log in before you can comment on or make changes to this bug.