Closed Bug 1268548 Opened 4 years ago Closed 4 years ago

Count when we show the addon compatibility dialog after update

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox47 --- fixed
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: benjamin, Assigned: benjamin)

Details

Attachments

(1 file)

After an update that changes versions, sometimes the addon manager shows a compatibility dialog. I don't remember what this dialog actually does, but we want to know how often this is shown because it may be one of the more common reasons that users see Firefox updates. In general we want Firefox updates to be silent.

I thought this was filed, but I can't find it and it's easy, so I'm just going to file again.
Comment on attachment 8746622 [details]
MozReview Request: Bug 1268548 - Add telemetry for when the addon manager upgrade dialog is shown, r?rhelmber

https://reviewboard.mozilla.org/r/49485/#review46327

::: toolkit/mozapps/extensions/internal/XPIProvider.jsm:2936
(Diff revision 1)
>     *         Array opf addon IDs that were disabled by the application update, and
>     *         should therefore be checked for updates.
>     */
>    showUpgradeUI: function(aAddonIDs) {
>      logger.debug("XPI_showUpgradeUI: " + aAddonIDs.toSource());
> +    Services.telemetry.getHistogramById("ADDON_MANAGER_UPGRADE_UI_SHOWN").add(1);

missing indent
Attachment #8746622 - Flags: review?(rhelmer) → review+
https://reviewboard.mozilla.org/r/49485/#review46327

> missing indent

Oops this actually is correct, just didn't look that way in mozreview: https://i.imgur.com/dRTnqdA.png
https://hg.mozilla.org/mozilla-central/rev/b3b5c46d5f59
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment on attachment 8746622 [details]
MozReview Request: Bug 1268548 - Add telemetry for when the addon manager upgrade dialog is shown, r?rhelmber

Approval Request Comment
[Feature/regressing bug #]: New data collection
[User impact if declined]: We won't know how many users see the addon-compat dialog and therefore are annoyed by Firefox upgrades until this hits release.
[Describe test coverage new/current, TreeHerder]: Manual testing only; I couldn't construct a reliable automated test.
[Risks and why]: AFAICT this is very low risk. A single telemetry call.
[String/UUID change made/needed]: none
Attachment #8746622 - Flags: approval-mozilla-beta?
Attachment #8746622 - Flags: approval-mozilla-aurora?
Comment on attachment 8746622 [details]
MozReview Request: Bug 1268548 - Add telemetry for when the addon manager upgrade dialog is shown, r?rhelmber

Was manually verified, new telemetry data, Aurora48+, Beta47+
Attachment #8746622 - Flags: approval-mozilla-beta?
Attachment #8746622 - Flags: approval-mozilla-beta+
Attachment #8746622 - Flags: approval-mozilla-aurora?
Attachment #8746622 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.