Closed
Bug 1268677
Opened 8 years ago
Closed 8 years ago
embedded object index might be no updated
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | + | fixed |
firefox49 | --- | fixed |
People
(Reporter: surkov, Assigned: surkov)
References
Details
(Keywords: regression)
Attachments
(1 file)
3.06 KB,
patch
|
yzen
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8746758 -
Flags: review?(yzenevich)
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=31ede417520a
Comment 2•8 years ago
|
||
[Tracking Requested - why for this release]: Regression fix from reorg bug 1255009 and bug 1261425. Requesting tracking to make sure this lands on Aurora once fixed on 49.
Comment 3•8 years ago
|
||
Observation with the try server build on this bug: Until recently, there was a bug in Firefox that affected the table containing the tracking flags on a Bugzilla bug like this one. Initially, that table is hidden. Once you click the Edit link next to the "Tracking Flags:" text, the table gets inserted into the accessibility tree that contains all of those tracking flags. A table with about 20 rows or so. When this happened, NVDA's virtual buffer always needed a refresh to see that table. Other dynamic insertions were no problem, just this particular one. So the steps were, with NVDA running: 1. Find the Edit link next to the "Tracking Flags:" text, and press Enter on it. 2. Notice that the table wasn't there that actually contained these flags. 3. Press NVDA+F5 to refresh the virtual buffer. Result: Table below the "Tracking Flags:" text was now present. After bug 1255009 and bug 1261425 landed, this bug went away. The table would now always appear right below the text without NVDA needing a refresh of the virtual buffer. With the patch on this bug now, the bug returns, but even stronger, because not even a virtual buffer refresh will now make that particular table visible. Again, it is the table that gets inserted when you click the Edit link next to the "Tracking Flags:" text when initially bringing up this bug. Perhaps this patch can be expanded to address this particular bug, since it seems very very closely related?
Assignee | ||
Comment 4•8 years ago
|
||
I filed a new bug 1268916 for Marco's issue, I don't find anything suspicious in code.
Comment 5•8 years ago
|
||
(In reply to alexander :surkov from comment #4) > I filed a new bug 1268916 for Marco's issue, I don't find anything > suspicious in code. That's totally fine with me. So Yura, feel free to review, and Surkov, to land, since this definitely improves things in other places, and it needs to get back-ported to Aurora, too.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → surkov.alexander
Comment 6•8 years ago
|
||
Comment on attachment 8746758 [details] [diff] [review] patch Review of attachment 8746758 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, one nit. ::: accessible/tests/mochitest/hypertext/test_update.html @@ +133,3 @@ > > + this.invoke = function removeFirstChild_invoke() > + { nit: whitespace
Attachment #8746758 -
Flags: review?(yzenevich) → review+
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bc628de412e5d63aae5ddb17d08e04b4d783197 Bug 1268677 - embedded object index might be not update, r=yzen
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0bc628de412e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 9•8 years ago
|
||
Comment on attachment 8746758 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: Bug 1255009 and bug 1261425 [User impact if declined]: Missing content in screen reader virtual buffers on Windows. [Describe test coverage new/current, TreeHerder]: Manual testing, has mochitest [Risks and why]: Low risk, corrects indexing. [String/UUID change made/needed]: None.
Attachment #8746758 -
Flags: approval-mozilla-aurora?
Comment 11•8 years ago
|
||
Comment on attachment 8746758 [details] [diff] [review] patch Fix for recent a11y regression
Attachment #8746758 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 12•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/e6ca64925a10
Updated•8 years ago
|
status-firefox47:
--- → unaffected
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•