1268833 - Corrupted window on Cisco SG200 web interface after innerText support

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Damian]

Attachment: Comparison - firefox 46 and chrome.

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160421124000

Steps to reproduce:

I'm using few Cisco SG200 switches - with web interface. When I go to VLAN Management -> Port VLAN Membership, and want to **** a new VLAN to the port - Firefox 46 open corrupted window (with no info on it). 

I have one old laptop with Firefox 38  - and this window work properly (windows is loading in it's full size, with all required data).



Actual results:

This happened since Firefox 44 - after FF update this window failed to work.


Expected results:

The expected results should be the same as on the screenshot (chrome window).

Comment 1

[Kohei Yoshino [:kohei]]

Are you seeing any errors in Firebug or Web Console?

https://developer.mozilla.org/en-US/docs/Tools/Web_Console/Opening_the_Web_Console

Firefox 44 had a bunch of changes so the "Join VLAN" popup code may be hitting one of them.

https://www.fxsitecompat.com/en-CA/versions/44/

Comment 2

[Damian]

No errors in Firebug. This popup is using some javascript so probably it's related to it.

Comment 3

[Loic]

Is it possible to test that? (maybe distant access to the router with guest account)

If not, could you save the page with the issue, and attach the archive to the bug report, please.
NB: verify the save of the interface page has the issue when loaded locally in Firefox.

Comment 4

[Damian]

Unfortunatelly can't give any access to this switch, because it's company production hardware.
Tried to save web page, but it doesn't include most things so it's useless.

Tried to install older firefox version, and I made a mistake. This problem started with Firefox 45 release, not 44.

Comment 5

[Kohei Yoshino [:kohei]]

Can you try this: https://addons.mozilla.org/en-US/firefox/addon/mozilla-archive-format/

Comment 6

[Damian]

Tried, it doesn't include javascripts which are required to open this popup window.

Comment 7

[YF (Yang)]

https://addons.mozilla.org/firefox/addon/scrapbook-x/ might can help.

Comment 8

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

Hi Damian,

Can you please retest this using the latest Nightly build (https://nightly.mozilla.org/) and report back the results ? When doing this, please use a new clean Firefox profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/PNe90E).

Thanks,
Paul.

Comment 9

[Damian]

Scrapbook-x doesn't work (exports blank page, even if I include JS to export).

Downloaded Nightly build 49.0a & created a new profile. Still the same bug.

Comment 10

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

Hi Damian,

Have you tried to reproduce this issue in safe mode?

Also, since you are the only one able to reproduce this issue, could you please try to find a regression range using Mozregression tool?
Information on the tool is available at http://mozilla.github.io/mozregression/. Please don't hesitate to contact us if you encounter any problems.

Thanks,
Paul.

Comment 11

[Damian]

Hello Paul,
Do you want whole log file, or only the last lines of log? I've been using MozRegression GUI for Windows.

Last log lines:

2016-05-04T13:37:26: INFO : Narrowed inbound regression window from [ca24bcc1, 9160f086] (3 revisions) to [798c82c8, 9160f086] (2 revisions) (~1 steps left)
2016-05-04T13:37:26: DEBUG : Starting merge handling...
2016-05-04T13:37:26: DEBUG : Using url: https://hg.mozilla.org/integration/mozilla-inbound/json-pushes?changeset=9160f08660b8290559e427fd80d617edd86fe2a6&full=1
2016-05-04T13:37:27: DEBUG : Found commit message:
Bug 264412. Optimize GetRenderedText. r=mats

Comment 12

[Loic]

Only the final pushlog, because its the smallest one to narrow down the regression.

Comment 13

[Damian]

Final Pushlog:

app_name: firefox
build_date: 2015-11-02 05:01:56.238000
build_file: C:\Documents and Settings\Administrator\.mozilla\mozregression\persist\798c82c8a96d-debug--mozilla-inbound--firefox-45.0a1.en-US.win32.zip
build_type: inbound
build_url: https://queue.taskcluster.net/v1/task/aEAWpuXQRIqgteqpUaCLCQ/runs/0/artifacts/public%2Fbuild%2Ffirefox-45.0a1.en-US.win32.zip
changeset: 798c82c8a96d1099cf712434d9c9036fc48d8297
pushlog_url: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=798c82c8a96d1099cf712434d9c9036fc48d8297&tochange=9160f08660b8290559e427fd80d617edd86fe2a6
repo_name: mozilla-inbound
repo_url: https://hg.mozilla.org/integration/mozilla-inbound
task_id: aEAWpuXQRIqgteqpUaCLCQ

Comment 14

[informatique]

have the same problem , have you found a solution ?

Comment 15

[Loic]

Matts, as roc left, who is in charge of this code area (innerText)?

Comment 16

[Mats Palmgren (inactive)]

So, adding support for .innerText in bug 264412 broke this web page for some reason.

We need to see the JS this page is running before deciding if this is a bug in
Firefox or not.  It seems most likely the problem is bad JS code (like bug 1260025
comment 3).

Comment 17

[informatique]

Attachment: Capture.PNG

Bug

Comment 18

[informatique]

Attachment: code.html code page of html

Comment 19

[informatique]

Attachment: gw.js

Comment 20

[informatique]

Attachment: portToVLANMembership_j.js

Comment 21

[Loic]

(In reply to informatique from comment #17)
> Created attachment 8766676 [details]
> Capture.PNG
> 
> Bug

I tried your testcase (by changing the paths of.js files in the .html file) but I see an emty list in FF47 and old versions like FF33, so I'm not what I should see. Could you attach a screenshot of the correct rendering of the page?

Maybe could you attach the file main.css too.

Comment 22

[Damian]

This page will be empty, because all data are gathered from device via ajax (or something similar).

Comment 23

[informatique]

Attachment: main.css

Comment 24

[informatique]

Attachment: Capture1.PNG

Comment 25

[Loic]

Is there a solution to populate locally the list?

Comment 26

[informatique]

In fact, this information is stored in the switch. I have no way to fill the local list . it is possible to give you access to my computer to access the switch ...

Comment 27

[neverreademaildumbnash]

I have same issue. I'm using ff48 on Zorin (Deb) Linux.  All pop up windows are not populated with options...

Comment 28

[Jonathan Kew [:jfkthame]]

Can someone with an affected system check whether this problem still exists in Firefox 51 and later (e.g. a current Developer Edition or Nightly build)? I'm wondering if the fix in bug 1290937 will have solved this as well.

Comment 29

[Damian]

Nightly 53.0a1 - issue still persist.

Comment 30

[ecujak]

Any progress on this? This has been going on for almost a year. All browsers work, except firefox. SG300 and SG500 with latest firmware. Latest release versions of firefox.

Comment 31

[Loic]

Mats, what's the solution here?

Comment 32

[Loic]

Removing NI flags.

Comment 33

[Mats Palmgren (inactive)]

We need to be able to reproduce the problem to analyze it.

I want to see what the content that works in Chrome looks like.
Can someone with an affected system visit the affected page *using Chrome*
and then save the page and upload it please?  (include all HTML/JS/CSS ...
if you can, preferably in a zip file).

Comment 34

[Damian]

Attachment: SG200 Join VLAN window captured from chrome.

SG200 Join VLAN window captured from chrome.

Comment 35

[Mats Palmgren (inactive)]

Thanks Damian.  The lists under "Select VLAN" are populated in the HTML file so they
show up just fine in Firefox when I load the HTML page.  So I think Chrome probably
saved HTML generated from the DOM in this case, so unfortunately it doesn't help
with analyzing why the lists aren't populated in Firefox.  The difference is
somewhere in the JS code that populates those <select> lists.  I don't see any
obvious errors when looking at the uses of .innerText in the JS files so it's
hard to say what went wrong.

BTW, you might want to check with the vendor (Cisco) if they have a newer
version of the software that fixes this problem.  Or report the problem
to them if not.

Comment 36

[Damian]

I've downloaded and upgraded firmware on the switch, but it's still the same.

Found some Cisco SG series device "emulators" available online: https://supportforums.cisco.com/community/911/cisco-small-business-online-device-emulators (right upper side: Smart or Managed Switches Online Device Emulators). I don't know it this will help it's a device emulator, not the real one. But when I run for example the last switch SG550XG-48T (https://www.cisco.com/assets/sol/sb/Switches_Emulators_v2_2_015/config/home_sg_550xg-48t_2_2.htm?simpDisp) - site it not displaying properly in FF, but in Chrome works well.

Comment 37

[cole]

Just stumbled on this bug I am experiencing the exact same issue.

At my company we are currently running Firefox 52.1.2 ESR and the latest Cisco SMB/SG firmware version 1.4.7.6

Comment 38

[Mats Palmgren (inactive)]

(In reply to Damian from comment #36)
> But when I run for example the last switch SG550XG-48T (https://www.cisco.com/assets/sol/sb/Switches_Emulators_v2_2_015/config/home_sg_550xg-48t_2_2.htm?simpDisp) - site it not displaying properly in FF, but in Chrome works well.

I tried this site in Firefox 53 on Linux and it appears to work fine for me.
Can you write down the exact steps you used that produces an error for you?

Comment 39

[cole]

(In reply to Mats Palmgren (:mats) from comment #38)
> (In reply to Damian from comment #36)
> > But when I run for example the last switch SG550XG-48T (https://www.cisco.com/assets/sol/sb/Switches_Emulators_v2_2_015/config/home_sg_550xg-48t_2_2.htm?simpDisp) - site it not displaying properly in FF, but in Chrome works well.
> 
> I tried this site in Firefox 53 on Linux and it appears to work fine for me.
> Can you write down the exact steps you used that produces an error for you?

Correct,

The emulators on Cisco's website are hilariously out of date. The "join vlan" pop out window works entirely different on the current versions of their firmware.

Comment 40

[Mats Palmgren (inactive)]

OK, thanks for confirming.

Have you tried Cisco's support channels?

Comment 41

[cole]

Attachment: Join VLAN - Internet Explorer.png

Internet Explorer on Windows 10 renders correctly

Cisco SMB/SG firmware version 1.4.7.6

Comment 42

[cole]

Attachment: Join VLAN - Firefox 53.03.png

Firefox 53.03 does not render correctly

Cisco SMB/SG firmware version 1.4.7.6

Comment 43

[cole]

I have not, I assumed it was a Firefox error since the other modern browsers that I tested functioned properly. Its not exactly a show stopping issue, just frustrating to have to switch away from my preferred browser.

Comment 44

[Mats Palmgren (inactive)]

I think it's rather unlikely to be a Firefox error since it started happening
after we added support for element.innerText (bug 264412).  It's seems more
likely that Cisco's web application is assuming that Firefox will never support
that and does something bad as a result.  Then again, I can't rule out that we
have a bug in our implementation without having something to analyze...

Comment 45

[cole]

I follow you,

I wish I could help by supplying you something. Anything I can log or inspect? Mail you a switch???

Comment 46

[cole]

(In reply to Mats Palmgren (:mats) from comment #44)
> I think it's rather unlikely to be a Firefox error since it started happening
> after we added support for element.innerText (bug 264412).  It's seems more
> likely that Cisco's web application is assuming that Firefox will never
> support
> that and does something bad as a result.  Then again, I can't rule out that
> we
> have a bug in our implementation without having something to analyze...

CONFIRMED!!!

When using a User Agent switcher addon "http://chrispederick.com/work/user-agent-switcher/" set to "Chrome 55.0 (Win 10 - 64 bit)" the Join VLAN window displays properly.

It looks as if Cisco is trying to make something specifically compatible with Firefox that is actually breaking it. I wonder if Cisco will even care since these are low-profit OEM/Rebranded small business switches acquired from their time with Linksys.

Comment 47

[Mats Palmgren (inactive)]

Thanks for your investigation.  I think that confirms that the problem is in
the web app, not in Firefox.