Closed
Bug 1268879
Opened 8 years ago
Closed 8 years ago
"complex" header missing in config/system-headers
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: wiz, Unassigned)
Details
Attachments
(1 file)
228 bytes,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:46.0) Gecko/20100101 Firefox/46.0 Build ID: 20160428084422 Steps to reproduce: Compiling on NetBSD-7.99.29/amd64 with gcc-5.3 fails with: Unified_cpp_dom_media_webaudio1.cpp:(.text+0x19e5): undefined reference to `__c99_cabs' Unified_cpp_dom_media_webaudio1.cpp:(.text+0x19fa): undefined reference to `__c99_cabs' ../../dom/media/webaudio/Unified_cpp_dom_media_webaudio1.o: In function `mozilla::FFTBlock::AddConstantGroupDelay(double)': Unified_cpp_dom_media_webaudio1.cpp:(.text+0x1d1d): undefined reference to `__c99_cabs' ../../dom/media/webaudio/Unified_cpp_dom_media_webaudio1.o: In function `mozilla::FFTBlock::ExtractAverageGroupDelay()': Unified_cpp_dom_media_webaudio1.cpp:(.text+0x1e85): undefined reference to `__c99_cabs' ../../dom/media/webaudio/blink/Unified_cpp_webaudio_blink0.o: In function `WebCore::Biquad::setZeroPolePairs(std::complex<double> const&, std::complex<double> const&)': Unified_cpp_webaudio_blink0.cpp:(.text+0x122b): undefined reference to `__c99_cabs' ../../dom/media/webaudio/blink/Unified_cpp_webaudio_blink0.o:Unified_cpp_webaudio_blink0.cpp:(.text+0x1259): more undefined references to `__c99_cabs' follow When adding "complex" to config/system-headers, the problem is fixed. Suggested patch against trunk from today is attached. Actual results: Build failure. Expected results: Build succeeds.
Attachment #8747060 -
Attachment is patch: true
Attachment #8747060 -
Flags: review?(gps)
Comment 1•8 years ago
|
||
Comment on attachment 8747060 [details] [diff] [review] patch-config_system-headers Review of attachment 8747060 [details] [diff] [review]: ----------------------------------------------------------------- Looks sane to me. I'll land this for you.
Attachment #8747060 -
Flags: review?(gps) → review+
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a1ca1b805353
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•