1268882 - unportable test operator in run-all-loop-tests.sh

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Thomas Klausner]

Attachment: Patch against trunk fixing the problem.

User Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160428084422

Steps to reproduce:

The file browser/extensions/loop/run-all-loop-tests.sh
contains:

if [ "$1" == "--help" ]; then

However, '==' as comparison operator is only supported by bash (not even GNU coreutils). '=' is the standard comparison operator for test(1).

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 8747062 [details] [diff] [review]
Patch against trunk fixing the problem.

Thanks for the patch. Looks good r=Standard8. I'll get this landed for you.

For future reference, its easier for reviewers to download & apply if you can generate patches in the git style, there's some more information on that here:

https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5c35538356c0

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5c35538356c0