1268976 - Assert that the micro-task queues are empty upon destruction of CycleCollectedJSRuntime

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Assert that the micro-task queues are empty upon destruction of CycleCollectedJSRuntime

While digging into bug 1261106, I thought that maybe we were leaving promises in
the micro-task queue, and I disproved that hypothesis, but I think this may be a
good assertion to keep around in general.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c01e650feb14

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8747271 [details] [diff] [review]
Assert that the micro-task queues are empty upon destruction of CycleCollectedJSRuntime

Review of attachment 8747271 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know anything about this code, but what's the worst that could happen with a couple of asserts...

Comment 4

[Andrew McCreight [:mccr8]]

FWIW, you should probably get reviews from khuey for these task queue things.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Looks fine.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dfaf20aac5d1

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dfaf20aac5d1