Assert that the micro-task queues are empty upon destruction of CycleCollectedJSRuntime

RESOLVED FIXED in Firefox 49

Status

()

Core
XPCOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8747271 [details] [diff] [review]
Assert that the micro-task queues are empty upon destruction of CycleCollectedJSRuntime

While digging into bug 1261106, I thought that maybe we were leaving promises in
the micro-task queue, and I disproved that hypothesis, but I think this may be a
good assertion to keep around in general.
Attachment #8747271 - Flags: review?(continuation)
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c01e650feb14
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Comment on attachment 8747271 [details] [diff] [review]
Assert that the micro-task queues are empty upon destruction of CycleCollectedJSRuntime

Review of attachment 8747271 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know anything about this code, but what's the worst that could happen with a couple of asserts...
Attachment #8747271 - Flags: review?(continuation) → review+
FWIW, you should probably get reviews from khuey for these task queue things.
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dfaf20aac5d1
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.