Closed Bug 1268982 Opened 8 years ago Closed 8 years ago

Generate a single unified rust library under LINK_GTEST

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox49 affected)

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox49 --- affected

People

(Reporter: rillian, Unassigned)

References

Details

We link rust code into gecko by generating a unified crate which references every crate we want to include. This is compiled to a staticlib from the unified source and rlib files built from all the individual crate sources.

Unfortunately we're doing this once for libxul and again for the gtest library, and linking both into the gtest-specific libxul, so we still end up with duplicate copies of library symbols.

We should merge the XUL-targeted crate list into toolkit/library/gtest/rul.rs and link only one of the two librul.a builds into libxul.so.
I think this is taken care of by using cargo to build things in bug 1231764.
Great.
Is this fixed then?
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> Is this fixed then?

Yes.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.