Closed Bug 1269049 Opened 10 years ago Closed 10 years ago

Remove UA override for Mobile Gmail

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: miketaylr, Assigned: miketaylr)

References

Details

Attachments

(1 file, 1 obsolete file)

Remove mobile Gmail UA override for Fennec.
1.79 KB, patch
miketaylr
: review+
Details | Diff | Splinter Review
Google has fixed a lot of things, and Gecko has learned a few new tricks since Bug 1184329. So let's remove it.
(In reply to Mike Taylor [:miketaylr] from comment #0) > Google has fixed a lot of things, and Gecko has learned a few new tricks > since Bug 1184329. So let's remove it. Errr, since Bug 1184320.
See Also: → 1184320
See Also: 1184329 →
I'm gonna test this a little bit more, so far it looks very promising!
The only difference I notice is we don't get the cool toolbar with the different Google apps. I don't think this is important enough to block on, so I think we should move forward.
Comment on attachment 8747388 [details] [diff] [review] Remove mobile Gmail UA override for Fennec. r=? Sebastian, would you mind rubber-stamping here?
Attachment #8747388 - Flags: review?(s.kaspari)
For the toolbar see also Bug 1239922 Agreed let's move on with this.
Comment on attachment 8747388 [details] [diff] [review] Remove mobile Gmail UA override for Fennec. r=? Review of attachment 8747388 [details] [diff] [review]: ----------------------------------------------------------------- *stamp*
Attachment #8747388 - Flags: review?(s.kaspari) → review+
Thanks!
Updating commit message w/ r=sebastian and carrying forward r+.
Attachment #8748195 - Flags: review+
Attachment #8747388 - Attachment is obsolete: true
Simple try run to prove this can build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c466728d2573 (no tests, because no tests look at the content of ua-update.json)
https://hg.mozilla.org/mozilla-central/rev/ec44576a2e10
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Blocks: 668275
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: