Closed Bug 1269157 Opened 4 years ago Closed 4 years ago
.fullscreen" as unprefixed version of Document .moz Full Screen
58 bytes, text/x-review-board-request
We have document.mozFullScreen but there is no corresponding unprefixed property in the spec. And it seems lack of that property could cause webcompat issue. See https://github.com/whatwg/fullscreen/issues/38 Adding this property should be a trivial work. But given this is another new regression reported, we may really want to hold back unprefixing Fullscreen API then.
yes, sounds like we need to disable the unprefixed API
I've had a patch, but I'd like to hold until patches in bug 1269276 get reviewed first.
Assignee: nobody → bugzilla
Kohei, FYI, we are going to add document.fullscreen in this bug as the unprefixed equivalent of document.mozFullScreen. You may want to add this to your fxsitecompat article.
Thanks! Mentioned this bug in the site compat doc. https://www.fxsitecompat.com/en-CA/docs/2016/fullscreen-api-has-been-unprefixed-in-non-release-builds/
Review commit: https://reviewboard.mozilla.org/r/51829/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51829/
Attachment #8751104 - Flags: review?(bugs)
Comment on attachment 8751104 [details] MozReview Request: Bug 1269157 - Add Document.fullscreen attribute. r?smaug https://reviewboard.mozilla.org/r/51829/#review48897 Our webidl bindings are so great.
Attachment #8751104 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a47ca5217c13181c46a9bb0ea7e868ed9130c5e8 Bug 1269157 - Add Document.fullscreen attribute. r=smaug
Created: https://developer.mozilla.org/en-US/docs/Web/API/Document/onfullscreenchange https://developer.mozilla.org/en-US/docs/Web/API/Document/onfullscreenerror Updated: https://developer.mozilla.org/en-US/Firefox/Releases/49#Others https://developer.mozilla.org/en-US/docs/Web/API/Document https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers
You need to log in before you can comment on or make changes to this bug.