Closed Bug 1269157 Opened 4 years ago Closed 4 years ago

Add "Document.fullscreen" as unprefixed version of Document.mozFullScreen

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

(Keywords: dev-doc-complete, Whiteboard: btpp-fixlater)

Attachments

(1 file)

We have document.mozFullScreen but there is no corresponding unprefixed property in the spec. And it seems lack of that property could cause webcompat issue. See https://github.com/whatwg/fullscreen/issues/38

Adding this property should be a trivial work. But given this is another new regression reported, we may really want to hold back unprefixing Fullscreen API then.
yes, sounds like we need to disable the unprefixed API
Blocks: 1269276
Whiteboard: btpp-fixlater
I've had a patch, but I'd like to hold until patches in bug 1269276 get reviewed first.
Assignee: nobody → bugzilla
Kohei, FYI, we are going to add document.fullscreen in this bug as the unprefixed equivalent of document.mozFullScreen. You may want to add this to your fxsitecompat article.
Comment on attachment 8751104 [details]
MozReview Request: Bug 1269157 - Add Document.fullscreen attribute. r?smaug

https://reviewboard.mozilla.org/r/51829/#review48897

Our webidl bindings are so great.
Attachment #8751104 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/a47ca5217c13
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Oups sorry, wrong bug.
Depends on: 1364025
Depends on: 1437265
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.