1269157 - Add "Document.fullscreen" as unprefixed version of Document.mozFullScreen

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

We have document.mozFullScreen but there is no corresponding unprefixed property in the spec. And it seems lack of that property could cause webcompat issue. See https://github.com/whatwg/fullscreen/issues/38

Adding this property should be a trivial work. But given this is another new regression reported, we may really want to hold back unprefixing Fullscreen API then.

Comment 1

[Olli Pettay [:smaug][[e-mail]] (vacation-ish -> Aug 1)]

yes, sounds like we need to disable the unprefixed API

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

I've had a patch, but I'd like to hold until patches in bug 1269276 get reviewed first.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Kohei, FYI, we are going to add document.fullscreen in this bug as the unprefixed equivalent of document.mozFullScreen. You may want to add this to your fxsitecompat article.

Comment 4

[Kohei Yoshino [:kohei]]

Thanks! Mentioned this bug in the site compat doc. https://www.fxsitecompat.com/en-CA/docs/2016/fullscreen-api-has-been-unprefixed-in-non-release-builds/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1269157 - Add Document.fullscreen attribute. r?smaug

Review commit: https://reviewboard.mozilla.org/r/51829/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51829/

Comment 6

[Olli Pettay [:smaug][[e-mail]] (vacation-ish -> Aug 1)]

Comment on attachment 8751104 [details]
MozReview Request: Bug 1269157 - Add Document.fullscreen attribute. r?smaug

https://reviewboard.mozilla.org/r/51829/#review48897

Our webidl bindings are so great.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a47ca5217c13181c46a9bb0ea7e868ed9130c5e8
Bug 1269157 - Add Document.fullscreen attribute. r=smaug

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a47ca5217c13

Comment 9

[Jean-Yves Perrier [:teoli]]

Created: 
https://developer.mozilla.org/en-US/docs/Web/API/Document/onfullscreenchange
https://developer.mozilla.org/en-US/docs/Web/API/Document/onfullscreenerror
Updated: 
https://developer.mozilla.org/en-US/Firefox/Releases/49#Others
https://developer.mozilla.org/en-US/docs/Web/API/Document
https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers

Comment 10

[Jean-Yves Perrier [:teoli]]

Oups sorry, wrong bug.

Comment 11

[Jean-Yves Perrier [:teoli]]

This time it is done:
https://developer.mozilla.org/en-US/docs/Web/API/Document/fullscreen
and
https://developer.mozilla.org/en-US/Firefox/Releases/49#Others