Closed Bug 1269175 Opened 4 years ago Closed 4 years ago

Convert nsStyleSVG::mStrokeDasharray to be nsTArray

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(1 file)

File per bug 1267524 comment 25. We should convert nsStyleSVG::mStrokeDasharray to be a nsTArray so that we don't need to worry about memory management.

[1] https://dxr.mozilla.org/mozilla-central/rev/1461a4071341c282afcf7b72e33036412d2251d4/layout/style/nsStyleStruct.h#3287
Attachment #8756719 - Flags: review?(cam)
https://reviewboard.mozilla.org/r/55358/#review52112

::: layout/style/nsRuleNode.cpp
(Diff revision 1)
>    case eCSSUnit_Inherit:
>    case eCSSUnit_Unset:
>      conditions.SetUncacheable();
>      svg->mStrokeDasharrayFromObject = parentSVG->mStrokeDasharrayFromObject;
> -    // only do the copy if weren't already set up by the copy constructor
> +    svg->mStrokeDasharray = parentSVG->mStrokeDasharray;
> -    // FIXME Bug 389408: This is broken when aStartStruct is non-null!

I guess bug 389408 is also fixed by this patch then.
See Also: → 389408
Assignee: nobody → tlin
Status: NEW → ASSIGNED
Comment on attachment 8756719 [details]
MozReview Request: Bug 1269175 - Convert nsStyleSVG::mStrokeDasharray to be nsTArray.

https://reviewboard.mozilla.org/r/55358/#review52770

Looks great, thanks!
Attachment #8756719 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/885f01dee6d2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.