1269175 - Convert nsStyleSVG::mStrokeDasharray to be nsTArray

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

File per bug 1267524 comment 25. We should convert nsStyleSVG::mStrokeDasharray to be a nsTArray so that we don't need to worry about memory management.

[1] https://dxr.mozilla.org/mozilla-central/rev/1461a4071341c282afcf7b72e33036412d2251d4/layout/style/nsStyleStruct.h#3287

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: MozReview Request: Bug 1269175 - Convert nsStyleSVG::mStrokeDasharray to be nsTArray.

Review commit: https://reviewboard.mozilla.org/r/55358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55358/

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://reviewboard.mozilla.org/r/55358/#review52112

::: layout/style/nsRuleNode.cpp
(Diff revision 1)
>    case eCSSUnit_Inherit:
>    case eCSSUnit_Unset:
>      conditions.SetUncacheable();
>      svg->mStrokeDasharrayFromObject = parentSVG->mStrokeDasharrayFromObject;
> -    // only do the copy if weren't already set up by the copy constructor
> +    svg->mStrokeDasharray = parentSVG->mStrokeDasharray;
> -    // FIXME Bug 389408: This is broken when aStartStruct is non-null!

I guess bug 389408 is also fixed by this patch then.

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8756719 [details]
MozReview Request: Bug 1269175 - Convert nsStyleSVG::mStrokeDasharray to be nsTArray.

https://reviewboard.mozilla.org/r/55358/#review52770

Looks great, thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/885f01dee6d2

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/885f01dee6d2