1269219 - Updating from about:home fails on Nightly49.0a1

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Alice0775 White]

STR:
1. Disabled autoupdate (app.update.enabled = false)
2. Start old Nightly(eg 2016-04-30)
3. Help > About Nightly
4. Click [Check for Updates] and wait for a seconds
5. Click [Update to 49.0a1]

Actual Results:
Nothing happens

Error in Browser console:

TypeError: gAppUpdater.doUpdate is not a function
aboutDialog.xul:1:1

Expected Results:
Download should start

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8c3fd523d75bd30f691ca2d6cfdad18d576392a1&tochange=2b7c421063ad7e30b6491d62ed8480ca333b628a

Suspect:
	c9950dbf1b5b	Robert Strong — Bug 1268340 - Change app.update.promptWaitTime preference to 8 days on the release (includes beta) and aurora channels. r=felipc
	5cc5a70ab42b	Robert Strong — Bug 1268343 - Remove toast notifications from application update. r=mhowell
	3cf22d1e586f	Robert Strong — Bug 1267891 - browser changes - Remove license capability from application update. r=felipc
	14bbaaf6575d	Robert Strong — Bug 1267891 - toolkit changes - Remove license capability from application update. r=mhowell
	b8c93b012f97	Robert Strong — Bug 1267891 - test changes - Remove license capability from application update. r=mhowell
	21d44aabf4a7	Robert Strong — Bug 1262880 - browser preferences changes - Remove add-on compatibility check from application update. r=felipc
	e37fe91ac862	Robert Strong — Bug 1262880 - browser changes - Remove add-on compatibility check from application update. r=felipc
	3f10077564b2	Robert Strong — Bug 1262880 - toolkit changes - Remove add-on compatibility check from application update. r=mhowell
	c66fda86cb1d	Robert Strong — Bug 1262880 - test changes - Remove add-on compatibility check from application update. r=mhowell

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: MozReview Request: Bug 1269219 - Replace remnant |gAppUpdater.doUpdate()| with |gAppUpdater.startDownload()| to fix updating from 'About Firefox' dialog. r?rstrong

Review commit: https://reviewboard.mozilla.org/r/50009/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50009/

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 8747708 [details]
MozReview Request: Bug 1269219 - Replace remnant |gAppUpdater.doUpdate()| with |gAppUpdater.startDownload()| to fix updating from 'About Firefox' dialog. r?rstrong

https://reviewboard.mozilla.org/r/50009/#review46805

Looks good to me and thanks!

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 8747708 [details]
MozReview Request: Bug 1269219 - Replace remnant |gAppUpdater.doUpdate()| with |gAppUpdater.startDownload()| to fix updating from 'About Firefox' dialog. r?rstrong

https://reviewboard.mozilla.org/r/50009/#review46807

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00624da185c4

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/00624da185c4

Comment 10

[Ajay Gupta]

Not sure if this problem is fixed in 20160503 build. I just tried updating it but I am seeing the similar behavior. Like before, I just downloaded the build from the ftp site and used it to upgrade my Nightly. What am I missing?

Comment 11

[baffclan]

reproduce with nightly(20160503030421)/Win64
Cannot update.

Comment 13

[Ajay Gupta]

An update of my previous email. After upgrading to build 20160504043118 (via ftp route), I just tried the update capability one more time and this time it worked fine. I guess the bug is licked in  	20160504043118 build.