1269249 - playing event not always fired if resume from stall is close to the end.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Jean-Yves Avenard [:jya]]

Seen in the new mochitest added in bug 1269178.

The mochitest dom/media/mediasource/test/test_FrameSelection_mp4.html loads some data and wait for the waiting event to be fired (as the video is missing data).

It then adds 3 video frames to the source buffer and wait for the "ended" event to be fired.

So we go from "waiting" to "ended", the "playing" event is never upon resuming from waiting mode.

By spec:
"Playback is ready to start after having been paused or delayed due to lack of media data. "

"readyState is newly equal to or greater than HAVE_FUTURE_DATA and paused is false, or paused is newly false and readyState is equal to or greater than HAVE_FUTURE_DATA. "

The problem here is that we change readyState to HAVE_FUTURE_DATA only if we have more then 250ms of data ahead of current time.

But here, being so close to the end of the video, there's only ~0.10s worth of data ahead.

We should clamp the interval to the element's duration so that "playing" is properly fired

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1269249: [MSE] P1. Clamp range to media source duration when media source is ended. r?jwwang

Review commit: https://reviewboard.mozilla.org/r/49957/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49957/

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1269249: [MSE] P2. Add mochitest verifying behavior. r?jwwang

Review commit: https://reviewboard.mozilla.org/r/49959/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49959/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8747587 [details]
MozReview Request: Bug 1269249: [MSE] P1. Clamp range to media source duration when media source is ended. r?jwwang

https://reviewboard.mozilla.org/r/49957/#review46877

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8747588 [details]
MozReview Request: Bug 1269249: [MSE] P2. Add mochitest verifying behavior. r?jwwang

https://reviewboard.mozilla.org/r/49959/#review46879

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d177920befc0
https://hg.mozilla.org/integration/mozilla-inbound/rev/57f7b48e73fa

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d177920befc0
https://hg.mozilla.org/mozilla-central/rev/57f7b48e73fa