Closed
Bug 1269262
Opened 8 years ago
Closed 8 years ago
config/external/icu/common/udata.o: undefined reference to `icudt56_dat'
Categories
(Core :: JavaScript: Internationalization API, defect)
Core
JavaScript: Internationalization API
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: jbeich, Unassigned)
References
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
ted
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
Firefox itself builds and runs fine but --enable-tests (default) does not if libjs_static.a isn't a static library (bug 702179). obj/js/src/libjs_static.a.desc before and after bug 1239083: LIBS = ... obj/config/external/icu/libicu.a ... vs. LIBS = ... obj/config/external/icu/i18n/libicui18n.a \ obj/config/external/icu/common/libicuuc.a \ ... _virtualenv/bin/python config/expandlibs_exec.py --uselist -- /usr/bin/clang++ -std=gnu++11 -Qunused-arguments -I/usr/local/include -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wclass-varargs -Wimplicit-fallthrough -Wloop-analysis -Wthread-safety -Wno-invalid-offsetof -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -O -fomit-frame-pointer -o PropertiesTest PropertiesTest.o -pthread -Wl,-z,noexecstack -Wl,-z,text -rdynamic -Wl,-rpath-link,dist/bin -Wl,-rpath-link,/usr/local/lib config/external/nspr/libnspr.a xpcom/glue/libxpcomglue_s.a mozglue/build/libmozglue.a memory/build/libmemory.a memory/fallible/libfallible.a js/src/libjs_static.a -pie config/external/nspr/pr/libnspr4.so config/external/nspr/libc/libplc4.so config/external/nspr/ds/libplds4.so toolkit/library/libxul.so -lm -pthread [...] config/external/icu/common/udata.o: In function `openCommonData(char const*, int, UErrorCode*)': intl/icu/source/common/udata.cpp:(.text._ZL14openCommonDataPKciP10UErrorCode+0x66): undefined reference to `icudt56_dat' /usr/bin/ld: config/external/icu/common/udata.o: relocation R_X86_64_PC32 against `icudt56_dat' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value https://svnweb.freebsd.org/ports/head/www/firefox/files/patch-bug702179?view=co
status-firefox48:
--- → affected
Review commit: https://reviewboard.mozilla.org/r/49989/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49989/
Attachment #8747652 -
Flags: review?(ted)
Updated•8 years ago
|
Attachment #8747652 -
Flags: review?(ted) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8747652 [details] MozReview Request: Bug 1269262 - Unbreak build without NO_EXPAND_LIBS in js/src/moz.build after bug 1239083. r?ted https://reviewboard.mozilla.org/r/49989/#review46711
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5991e7117793
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment on attachment 8747652 [details] MozReview Request: Bug 1269262 - Unbreak build without NO_EXPAND_LIBS in js/src/moz.build after bug 1239083. r?ted Approval Request Comment [Feature/regressing bug #]: bug 1239083 [User impact if declined]: --enable-dtrace is broken on FreeBSD and Solaris unless --with-system-icu [Describe test coverage new/current, TreeHerder]: m-c [Risks and why]: Broken build with non-default options [String/UUID change made/needed]: None
Attachment #8747652 -
Flags: approval-mozilla-aurora?
Comment 6•8 years ago
|
||
Comment on attachment 8747652 [details] MozReview Request: Bug 1269262 - Unbreak build without NO_EXPAND_LIBS in js/src/moz.build after bug 1239083. r?ted Fix for broken build in 48, please uplift to aurora.
Attachment #8747652 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/27e01af4af57
You need to log in
before you can comment on or make changes to this bug.
Description
•