1269268 - Intermittent leakcheck | default process: 212 bytes leaked (CondVar, Mutex, Runnable, nsTArray_base, nsThread)

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Carsten Book [:Tomcat]]

00:59:55 WARNING - TEST-UNEXPECTED-FAIL | leakcheck | default process: 212 bytes leaked (CondVar, Mutex, Runnable, nsTArray_base, nsThread) 

https://treeherder.mozilla.org/logviewer.html#?job_id=27032481&repo=mozilla-inbound

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

The bug here is that the calling thread is already shut down by the time we try to come back to it to call nsIThread::Shutdown on the camera thread.  The calling thread is a chromium thread, so the nsThread for it is automatically created by the thread manager and will accept events even when there's no chance that they will ever run so we get the leak.

Thankfully, we can just shut down the camera thread from a thread we know will be alive.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03540c2e61c1

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8353213efc26

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03540c2e61c1
https://hg.mozilla.org/mozilla-central/rev/8353213efc26