126930 - SSL_ConfigServerSessionIDCache does not work on OS/2

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Julien Pierre]

After building NSS standalone on OS/2, I tried running selfserv. After getting
past bug 126928 by commenting some calls, I ran into this :

[D:\nss\mozilla\dist\os22.45_icc_dbg.obj\bin]test
selfserv: SSL_ConfigServerSessionIDCache returned error -5992:
function not implemented.

Debugging showed that the problem was that PR_OpenAnonFileMap was getting called
within mozilla/security/nss/lib/ssl/sslsnce.c . That function is currently not
implemented in the OS/2 NSPR. I will open a separate bug for that.

Ultimately though, I think the SSL session cache layer could deal with things a
little bit differently and allocate regular memory rather than shared memory if
multi-process mode was not required. Since we have different APIs to setup the
multi-process SID cache and single-process one, this is feasible. Right now the
MP function just calls the UP function and shared memory is always used, which
causes this failure. I believe this problem is the major snag to running SSL
servers on OS/2 right now. If this memory mapped file allocation can be replaced
with a simple malloc, I will try it.

Comment 1

[Julien Pierre]

I replaced the PR_OpenAnonFileMap with a PR_Malloc. The next problem was that
PR_MemMap was being called. That one isn't implemented on OS/2 either - and
cannot be, since the OS/2 kernel doesn't have memory-mapped file support.
Again this mapping isn't necessary for a single-process server. We should not be
calling mmap when running a single-process SSL server.

After I removed that mmap call, the SSL server came up on OS/2, and even
appeared to run fine !

Comment 2

[Wan-Teh Chang]

Julien,

Yes, in single-process mode, we should use PR_Malloc (or PORT_Alloc)
to allocate the server session ID cache and use PRLocks to protect
them.  I believe you did the latter as your first NSS assignment.
I've wanted to have the former done but have not got around to
opening a bug.  Thanks.

Comment 3

[Wan-Teh Chang]

Changed the QA contact to Bishakha.

Comment 4

[Wan-Teh Chang]

Set target milestone to NSS 3.5.

Comment 5

[Mike Kaply [:mkaply]]

Is this really an Os/2 specific issue now?

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Yes, the bug is OS/2 specific.  It works on other platforms.
However, it is possible that the fix will change the code used on other 
platforms also.

Comment 7

[Julien Pierre]

Well, there may be other platforms on which the NSPR functions needed here
aren't implemented, since they aren't used in the client. But on Win32, Mac OS X
and all Unix platforms, these functions are implemented, so this works on the
majority of platforms. This bug prevents running SSL servers on OS/2 or any
other platform that's missing these NSPR functions.

Comment 8

[Wan-Teh Chang]

Assigned the bug to Julien.

Comment 9

[Julien Pierre]

Attachment: Use PR_Malloc when creating the session cache in single-process mode.

Comment 10

[Julien Pierre]

Wan-Teh or Nelson,
Could you please review this patch ? Thanks.

Comment 11

[Julien Pierre]

Attachment: new patch

a) always zero the cache, regardless of whether shared memory is used or not
b) be more consistent with cacheMemMap and sharedMem variables between the
shared-memory and non-shared-memory cases

Comment 12

[Julien Pierre]

Attachment: latest patch

- correctly catch all allocation errors
- replace PR_Malloc / PR_Free with PORT_Alloc / PORT_Free which are used
throughout NSS

Comment 13

[Julien Pierre]

Attachment: last patch

remove unnecessary if sharedMem test

As checked in to the tip.

Checking in sslsnce.c;
/cvsroot/mozilla/security/nss/lib/ssl/sslsnce.c,v  <--	sslsnce.c
new revision: 1.23; previous revision: 1.22
done

Comment 14

[Julien Pierre]

Fixed.