1269315 - Add a menu item for the open the home page.

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[James Hugman [:jhugman] [@jhugman]]

This is just the menu item, and going to the home page.

https://bugzilla.mozilla.org/show_bug.cgi?id=1260449
https://mozilla.invisionapp.com/share/MT6WKBP38#/screens/144445285

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Attachment: Pull request

Comment 2

[Stephan Leroux [:sleroux]]

I can't seem to see the PR for this bug. When I click on the attachment it brings me to bugzilla and I don't see it in the PR listing on Github?

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8747656 [details]
Pull request

https://github.com/mozilla/firefox-ios/pull/1769

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Attachment: Pull request

Added missing PR link.

Comment 5

[Stephan Leroux [:sleroux]]

Comment on attachment 8747767 [details] [review]
Pull request

Looks good - just a question about having a hardcoded default.

Comment 6

[James Hugman [:jhugman] [@jhugman]]

Hardcoded default is only needed until Bug 1265345 and this one are both fixed.

Merged into https://github.com/mozilla/firefox-ios/pull/1772 (i.e. not master).

Comment 7

[James Hugman [:jhugman] [@jhugman]]

Merged into https://github.com/mozilla/firefox-ios/pull/1772 (PR for Bug 1260449).