1269352 - Synced Tabs search box responds slowly after using it a few times

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Ryan Feeley [:rfeeley]]

Attachment: slow-synced-tabs-sidebar-search.png

I noticed that when I type repeated queries into the synced tabs sidebar that the filter starts to respond slowly. Attached is a screenshot of query that took about 10 seconds to respond.

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1269352.patch

Very good catch Ryan!
The view's _create function is called every time we clear the search, the problem is it was creating duplicate listeners for UI components that were not deleted or changed in anyway.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8748306 [details] [diff] [review]
bug-1269352.patch

Review of attachment 8748306 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!

::: browser/components/syncedtabs/TabListView.js
@@ +80,3 @@
>      this.list = this.container.querySelector(".list");
>  
> +    this.list.addEventListener("click", this.onClick.bind(this));

I think it would be clearer to have a new function _attachListListeners (and optionally renaming the existing one to _attachFixedListeners or similar) with a comment indicating that the new one needs to be called each time the list is recreated and the other one once. I'm just concerned that someone later will think the fact we didn't add these into addListeners was an oversight.

Comment 3

[Edouard Oger [:eoger]]

Attachment: bug-1269352.patch

Carrying r+ forward with fixes

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/35f90f41182e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/35f90f41182e