1269436 - Always pass the principal to push observer notifications

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Lina Butler (ex-Mozilla)]

Attachment: pushObserverPrincipals.patch

It occurred to me that we don't pass the subscription principal to any of the push observers. I suspect this might be an issue when we eventually start using origin attributes (like `userContextId`).

"push-subscription-change" and "push-subscription-refresh" don't currently have a subject, so we can pass the principal directly to them.

"push-message" takes an optional nsIPushMessage; for that case, I think we'll want to change nsIPushMessage to a wrapper, and pass the actual data as an attribute. JS callers need to null-check and QI to nsIPushMessage, anyway, so I don't think this makes things any more complicated.

Comment 1

[Dragana Damjanovic [:dragana]]

Comment on attachment 8747828 [details] [diff] [review]
pushObserverPrincipals.patch

Review of attachment 8747828 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/push/PushNotifier.cpp
@@ +472,5 @@
> +PushMessage::GetPrincipal(nsIPrincipal** aPrincipal)
> +{
> +  if (!aPrincipal) {
> +    return NS_ERROR_INVALID_ARG;
> +  }

we could use  NS_ENSURE_ARG_POINTER here?

Comment 2

[Lina Butler (ex-Mozilla)]

(In reply to Dragana Damjanovic [:dragana] from comment #1)
> we could use  NS_ENSURE_ARG_POINTER here?

Good call, thanks! Added NS_ENSURE_ARG{_POINTER} to the other methods, too. Carrying r+ forward.

I had to rename "nsIPushMessageData" to "nsIPushData," since it conflicts with the refcount tracing for the WebIDL interface: https://treeherder.mozilla.org/logviewer.html#?job_id=20274692&repo=try It's also shorter. :-)

Comment 3

[Lina Butler (ex-Mozilla)]

Attachment: pushObserverPrincipals.patch

Comment 4

[Lina Butler (ex-Mozilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d25c07e2f368

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aaa6c0e38d61

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aaa6c0e38d61