1269448 - 8,400 instances of "NS_ENSURE_TRUE(aURI) failed" emitted from netwerk/cache2/CacheStorage.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Eric Rahm [:erahm]]

> 8396 WARNING: NS_ENSURE_TRUE(aURI) failed: file netwerk/cache2/CacheStorage.cpp, line 63

This warning [1] shows up in the following test suites:

>   1080 - [TC] Linux64 web-platform-tests-reftests Wr
>    583 - [TC] Linux64 web-platform-tests-5 5
>    461 - [TC] Linux64 reftest-5 R5
>    428 - [TC] Linux64 mochitest-5 5
>    381 - [TC] Linux64 mochitest-2 2
>    351 - [TC] Linux64 mochitest-6 6
>    285 - [TC] Linux64 mochitest-chrome-1 c1
>    272 - [TC] Linux64 reftest-1 R1
>    258 - [TC] Linux64 web-platform-tests-6 6
>    240 - [TC] Linux64 mochitest-browser-chrome-5 bc5
>    240 - [TC] Linux64 mochitest-browser-chrome-7 bc7
>    229 - [TC] Linux64 reftest-8 R8
>    228 - [TC] Linux64 web-platform-tests-8 8
>    187 - [TC] Linux64 mochitest-browser-chrome-2 bc2
>    180 - [TC] Linux64 web-platform-tests-2 2
>    178 - [TC] Linux64 web-platform-tests-3 3
>    169 - [TC] Linux64 mochitest-browser-chrome-1 bc1
>    160 - [TC] Linux64 mochitest-devtools-chrome-10 dt10
>    147 - [TC] Linux64 mochitest-chrome-3 c3
>    132 - [TC] Linux64 mochitest-devtools-chrome-8 dt8
>    130 - [TC] Linux64 mochitest-browser-chrome-3 bc3
>    125 - [TC] Linux64 reftest-6 R6
>    119 - [TC] Linux64 mochitest-browser-chrome-4 bc4
>    116 - [TC] Linux64 mochitest-9 9
>    106 - [TC] Linux64 mochitest-devtools-chrome-9 dt9
>     99 - [TC] Linux64 mochitest-browser-chrome-6 bc6
>     85 - [TC] Linux64 mochitest-7 7
>     83 - [TC] Linux64 mochitest-devtools-chrome-7 dt7
>     82 - [TC] Linux64 mochitest-devtools-chrome-4 dt4
>     81 - [TC] Linux64 mochitest-3 3
>     73 - [TC] Linux64 firefox-ui-tests functional en-US
>     70 - [TC] Linux64 mochitest-devtools-chrome-6 dt6
>     68 - [TC] Linux64 mochitest-browser-chrome-e10s-5 bc5
>     64 - [TC] Linux64 mochitest-chrome-2 c2
>     61 - [TC] Linux64 mochitest-devtools-chrome-2 dt2
>     56 - [TC] Linux64 reftest-4 R4
>     56 - [TC] Linux64 mochitest-browser-chrome-e10s-3 bc3
>     52 - [TC] Linux64 mochitest-browser-chrome-e10s-1 bc1
>     47 - [TC] Linux64 reftest-3 R3
>     46 - [TC] Linux64 mochitest-browser-chrome-e10s-4 bc4
>     42 - [TC] Linux64 mochitest-devtools-chrome-5 dt5
>     41 - [TC] Linux64 mochitest-10 10
>     40 - [TC] Linux64 mochitest-media mda
>     38 - [TC] Linux64 reftest-7 R7
>     37 - [TC] Linux64 mochitest-devtools-chrome-3 dt3
>     35 - [TC] Linux64 mochitest-1 1
>     32 - [TC] Linux64 mochitest-4 4
>     30 - [TC] Linux64 mochitest-8 8
>     19 - [TC] Linux64 mochitest-plain-e10s-5 5
>     18 - [TC] Linux64 reftest-2 R2
>     17 - [TC] Linux64 mochitest-plain-e10s-9 9
>     16 - [TC] Linux64 mochitest-plain-e10s-10 10
>     16 - [TC] Linux64 mochitest-plain-e10s-7 7
>     16 - [TC] Linux64 mochitest-plain-e10s-1 1
>     15 - [TC] Linux64 mochitest-plain-e10s-3 3
>     15 - [TC] Linux64 mochitest-devtools-chrome-1 dt1
>     13 - [TC] Linux64 mochitest-plain-e10s-4 4
>     13 - [TC] Linux64 web-platform-tests-e10s-5 5
>     13 - [TC] Linux64 mochitest-browser-chrome-e10s-2 bc2
>     12 - [TC] Linux64 mochitest-plain-e10s-2 2
>     12 - [TC] Linux64 mochitest-plain-e10s-8 8
>     11 - [TC] Linux64 firefox-ui-tests functional e10s en-US
>     11 - [TC] Linux64 mochitest-media-e10s mda
>     11 - [TC] Linux64 mochitest-browser-chrome-e10s-7 bc7
>     10 - [TC] Linux64 mochitest-a11y a11y
>     10 - [TC] Linux64 mochitest-plain-e10s-6 6
>      7 - [TC] Linux64 crashtest C
>      6 - [TC] Linux64 web-platform-tests-4 4
>      6 - [TC] Linux64 web-platform-tests-7 7
>      6 - [TC] Linux64 mochitest-jetpack JP
>      6 - [TC] Linux64 mochitest-gl gl
>      3 - [TC] Linux64 web-platform-tests-e10s-3 3
>      2 - [TC] Linux64 web-platform-tests-reftests-e10s Wr-e10s
>      2 - [TC] Linux64 web-platform-tests-e10s-6 6
>      2 - [TC] Linux64 mochitest-browser-chrome-e10s-6 bc6
>      2 - [TC] Linux64 web-platform-tests-1 1
>      1 - [TC] Linux64 web-platform-tests-e10s-2 2
>      1 - [TC] Linux64 web-platform-tests-e10s-8 8
>      1 - [TC] Linux64 web-platform-tests-e10s-7 7

It shows up in 3159 tests. A few of the most prevalent:

>    354 -        Shutdown
>    182 -        dom/security/test/cors/test_CrossSiteXHR_cache.html
>    160 -        dom/tests/mochitest/fetch/test_fetch_cors.html
>    160 -        dom/tests/mochitest/fetch/test_fetch_cors_sw_empty_reroute.html
>     88 -        dom/security/test/cors/test_CrossSiteXHR.html
>     66 -        dom/devicestorage/test/test_fs_app_permissions.html
>     63 -        dom/manifest/test/browser_ManifestObtainer_obtain.js
>     58 -        layout/style/test/test_font_loading_api.html
>     56 -        /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html
>     48 -        dom/security/test/cors/test_CrossSiteXHR_origin.html

[1] https://hg.mozilla.org/mozilla-central/annotate/77cead2cd203/netwerk/cache2/CacheStorage.cpp#l63

Comment 1

[Honza Bambas (:mayhemer)]

Has this shown recently?

Nick, could this be related to your predictor?

Comment 2

[Eric Rahm [:erahm]]

(In reply to Honza Bambas (:mayhemer) from comment #1)
> Has this shown recently?
> 
> Nick, could this be related to your predictor?

Looks like this regressed in bug 1016628, so I'm guessing yes.

Comment 3

[u408661]

Attachment: patch

Well that's an embarrassing mistake. Haven't even built this locally yet, let alone run the tests to make sure nothing crazy happens, but this should be what we need.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 8748428 [details] [diff] [review]
patch

Review of attachment 8748428 [details] [diff] [review]:
-----------------------------------------------------------------

I missed that!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ebf3313b6a43

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ebf3313b6a43