Assertion 'read_block == (pkt != ((void*)0))' failed [@nestegg_read_packet]

RESOLVED FIXED

Status

()

Core
Audio/Video: Playback
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tsmith, Assigned: kinetik)

Tracking

(Blocks: 1 bug, {assertion, testcase})

49 Branch
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 affected)

Details

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8747993 [details]
test_case.webm

Running the attached test case in a debug build will trigger the following assertion:

firefox: /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/media/libnestegg/src/nestegg.c:2419: int nestegg_read_packet(nestegg *, nestegg_packet **): Assertion `read_block == (pkt != ((void*)0))' failed.
(Reporter)

Comment 1

2 years ago
Created attachment 8747994 [details]
call_stack.txt
Flags: needinfo?(kinetik)
(Assignee)

Updated

2 years ago
Assignee: nobody → kinetik
Flags: needinfo?(kinetik)
(Assignee)

Updated

2 years ago
Blocks: 1267513
(Assignee)

Comment 2

2 years ago
The assert triggered here, which I added in bug 1267513, is incorrect.  It should be:

        assert(read_block == (*pkt != NULL));
(Assignee)

Comment 3

2 years ago
Created attachment 8748029 [details]
fix assert
Attachment #8748029 - Flags: review?(giles)
(Reporter)

Comment 4

2 years ago
Thanks Matthew!

Verified fixed with nestegg commit 046e10f
Comment on attachment 8748029 [details]
fix assert

oops!
Attachment #8748029 - Flags: review?(giles) → review+
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
(Assignee)

Comment 6

2 years ago
This landed with the libnestegg update in bug 1261900.
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.