1269532 - Assertion 'read_block == (pkt != ((void*)0))' failed [@nestegg_read_packet]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Tyson Smith [:tsmith]]

Attachment: test_case.webm

Running the attached test case in a debug build will trigger the following assertion:

firefox: /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/media/libnestegg/src/nestegg.c:2419: int nestegg_read_packet(nestegg *, nestegg_packet **): Assertion `read_block == (pkt != ((void*)0))' failed.

Comment 1

[Tyson Smith [:tsmith]]

Attachment: call_stack.txt

Comment 2

[Matthew Gregan [:kinetik]]

The assert triggered here, which I added in bug 1267513, is incorrect.  It should be:

        assert(read_block == (*pkt != NULL));

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: fix assert

Comment 4

[Tyson Smith [:tsmith]]

Thanks Matthew!

Verified fixed with nestegg commit 046e10f

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8748029 [details]
fix assert

oops!

Comment 6

[Matthew Gregan [:kinetik]]

This landed with the libnestegg update in bug 1261900.