Closed
Bug 1269653
Opened 9 years ago
Closed 9 years ago
Remove LayerManagerComposite access to nsIWidget
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
3.36 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
|
3.23 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Use CompositorBridgeParent::mApzcTreeManager to check if APZ is enabled instead of nsIWidget.
Attachment #8748080 -
Flags: review?(bugmail.mozilla)
|
||
Updated•9 years ago
|
Attachment #8748080 -
Flags: review?(bugmail.mozilla) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
We pass nsIWidget to SetDispAcquireFence, but it's already set in Compositor, and only Android needs it. When/if Android does OOP compositing we'll have to fix this call, but this unblocks Desktop for now.
Attachment #8748312 -
Flags: review?(bugmail.mozilla)
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8748312 [details] [diff] [review]
part 2, SetDispAcquireFence
Review of attachment 8748312 [details] [diff] [review]:
-----------------------------------------------------------------
s/Android/Gonk/ - but yeah this looks fine.
Attachment #8748312 -
Flags: review?(bugmail.mozilla) → review+
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3a4e68d0112b
https://hg.mozilla.org/mozilla-central/rev/2872b9050cab
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•