Closed Bug 1269731 Opened 4 years ago Closed 4 years ago

partner-repacks push to mirrors should work on reruns

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(2 files)

ATM we use 2 separate push to mirrors: the first starts when all deliverables except partner repacks are ready, the second starts when partner-repacks are ready.

In the following scenario the second push to mirrors fails:

1) a partner repack build starts, uploads some files
2) the first push to mirrors happens
3) a partner repack builder fails for some reason
4) another run of partner repacks runs and uploads different binaries to the candidates directory
5) partner-repacks push to mirrors fails because the files in 1) and 4) do not match

We should either optimize the partner repacks script to not overwrite the files or separate the push to mirrors scripts to not copy all files. I'd prefer the latter, probably.
Assignee: nobody → rail
Attached file PR
Attachment #8751368 - Flags: review?(bugspam.Callek)
Attachment #8751368 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8751368 [details] [review]
PR

merged and deployed
Attachment #8751368 - Flags: checked-in+
It turns out that adding --exclude overrides the default excludes. We don't pass --exclude anywhere except in this case, so I thought I can be brave and move things around a bit. :)
Attachment #8753169 - Flags: review?(nthomas) → review+
Comment on attachment 8753169 [details]
MozReview Request: Bug 1269731 - partner-repacks push to mirrors should work on reruns r=nthomas a=release DONTBUILD

https://reviewboard.mozilla.org/r/53052/#review49900

Given how we are using this right now it seems fine to switch the mode. The virus scanner code did something similar, but that's now replaced with TC tasks right ? Do we av scan partner builds ?

::: testing/mozharness/scripts/release/push-candidate-to-releases.py:56
(Diff revision 1)
> +                r"^.*robocop.apk$",
> +                r"^.*contrib.*",
> +                r"^.*/beetmover-checksums/.*$",
> +            ],
>              "action": "append",
> -            "help": "List of patterns to exclude from copy. See script source for default.",
> +            "help": "List of patterns to exclude from copy.",

Please modify the help to make it clear you can only extend the list of excludes.
Comment on attachment 8753169 [details]
MozReview Request: Bug 1269731 - partner-repacks push to mirrors should work on reruns r=nthomas a=release DONTBUILD

https://hg.mozilla.org/integration/mozilla-inbound/rev/3270563e2403
Attachment #8753169 - Flags: checked-in+
Keywords: leave-open
Comment on attachment 8753169 [details]
MozReview Request: Bug 1269731 - partner-repacks push to mirrors should work on reruns r=nthomas a=release DONTBUILD

aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/73cd8f727097
Worked find in 47.0b7 \o/
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.